src: use UTF-8 for task runner filesystem paths - #64868
Merged
nodejs-github-bot merged 1 commit intoAug 4, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This comment was marked as spam.
Copy link
Copy Markdown
Codecov Report❌ Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.
@@ Coverage Diff @@
## main #64868 +/- ##
==========================================
+ Coverage 90.14% 90.17% +0.02%
==========================================
Files 746 746
Lines 242763 242763
Branches 45761 45765 +4
==========================================
+ Hits 218848 218901 +53
+ Misses 15402 15346 -56
- Partials 8513 8516 +3
... and 36 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
anonrig
requested changes
Jul 31, 2026
anonrig
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Please add a test case
Sorry, something went wrong.
anonrig
approved these changes
Jul 31, 2026
Use ConvertPathToUTF8() instead of path::string() when passing filesystem paths to Node and libuv interfaces. This prevents paths containing characters outside the active Windows code page from being corrupted or rejected. Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
StefanStojanovic
approved these changes
Aug 3, 2026
StefanStojanovic
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Thanks for the ping. LGTM. I've triggered the CI, to verify the changes and the test you added.
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This comment was marked as spam.
aduh95
pushed a commit
that referenced
this pull request
Aug 13, 2026
Use ConvertPathToUTF8() instead of path::string() when passing filesystem paths to Node and libuv interfaces. This prevents paths containing characters outside the active Windows code page from being corrupted or rejected. Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com> PR-URL: #64868 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use ConvertPathToUTF8() instead of path::string() when passing filesystem paths to Node and libuv interfaces. This prevents paths containing characters outside the active Windows code page from being corrupted or rejected.