dns: validate address type in lookupService - #64878
Merged
nodejs-github-bot merged 1 commit intoAug 21, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Signed-off-by: Lazizbek Ergashev <lazerg2@gmail.com>
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #64878 +/- ##
=======================================
Coverage 90.16% 90.17%
=======================================
Files 746 746
Lines 242763 242768 +5
Branches 45761 45768 +7
=======================================
+ Hits 218898 218921 +23
+ Misses 15352 15321 -31
- Partials 8513 8526 +13
... and 35 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
theanarkh
approved these changes
Aug 1, 2026
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
pimterry
approved these changes
Aug 3, 2026
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dns.lookupService() and dns.promises.lookupService() abort the process with a native assertion when address is a non-string that still coerces to a valid IP, like a Buffer. isIP() stringifies its argument, so the existing guard passes and the raw value reaches the C++ binding, where it trips CHECK(args[1]->IsString()). Validating that address is a string first, as dgram already does, makes a bad type throw ERR_INVALID_ARG_TYPE instead of crashing.
Fixes: #64877