test: fix lint in dtls tests - #64902
Conversation
Sorry, something went wrong.
a7d16a8 introduced destructured uses of assert and fixtures, which the test lint rules forbid, plus bare strictEqual/throws calls that were never imported and threw ReferenceError at runtime. Use the assert and fixtures namespaces directly. Signed-off-by: Matteo Collina <hello@matteocollina.com>
|
Fast-track has been requested by @mcollina. Please 👍 to approve. This fixes lint-js-and-md which is currently failing on main and on every open PR. |
Sorry, something went wrong.
|
Fast-track has been requested by @mcollina. Please 👍 to approve. |
Sorry, something went wrong.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #64902 +/- ##
==========================================
+ Coverage 90.13% 90.15% +0.02%
==========================================
Files 746 746
Lines 242893 242893
Branches 45769 45766 -3
==========================================
+ Hits 218935 218985 +50
+ Misses 15444 15390 -54
- Partials 8514 8518 +4 see 33 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
Sorry, something went wrong.
jasnell
left a comment
There was a problem hiding this comment.
Weird, these didn't show up for me locally when I linted. Wonder if I have something out of sync. Thanks for catching!
Sorry, something went wrong.
It seems to have been clobbered by #64716 |
Sorry, something went wrong.
a7d16a8 introduced destructured uses of assert and fixtures, which the test lint rules forbid, plus bare strictEqual/throws calls that were never imported and threw ReferenceError at runtime. Use the assert and fixtures namespaces directly. Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #64902 Reviewed-By: Mike McCready <66998419+MikeMcC399@users.noreply.github.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
a7d16a8 introduced destructured uses of assert and fixtures in the dtls tests, which the test lint rules forbid (no-restricted-syntax), so lint-js-and-md is currently failing on main and on every open PR.
Two of the files (test-dtls-alpn.mjs, test-dtls-options.mjs) also called bare strictEqual/throws that were never imported at all — those threw ReferenceError at runtime when the assertions ran.
This uses the assert and fixtures namespaces directly throughout, matching the rest of the test suite.
All 25 test-dtls-* tests pass locally on this branch and make lint-js is clean.
cc @jasnell