ffi: reuse libffi call plans - #64958
Merged
nodejs-github-bot merged 2 commits intoAug 4, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Precompute a libffi call plan for each fixed signature on x86-64 System V and reuse it from the generic and SharedBuffer invokers. This avoids repeating argument-placement work for every call. Continue to use ffi_call() with libffi older than 3.7, on other ABIs, and when plan allocation fails. Signed-off-by: umuoy1 <burningdian@gmail.com>
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report❌ Patch coverage is 96.42857% with 1 line in your changes missing coverage. Please review.
@@ Coverage Diff @@
## main #64958 +/- ##
==========================================
- Coverage 90.28% 90.28% -0.01%
==========================================
Files 760 762 +2
Lines 247076 247536 +460
Branches 46594 46680 +86
==========================================
+ Hits 223081 223484 +403
- Misses 15458 15495 +37
- Partials 8537 8557 +20
... and 55 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
Measure the call path for signatures that bypass the V8 Fast API and reach FFIFunction::Invoke(), covering a register-only and a stack-spilled libffi call plan on x86-64 System V. The per-call delta is the decision-relevant metric for reusable call plans: plan allocation is a one-time cost that amortizes within a few calls. Signed-off-by: umuoy1 <burningdian@gmail.com>
umuoy1
force-pushed
the
ffi-reuse-call-plans
branch
from
6d678be to
249d729
Compare
August 3, 2026 09:51
mcollina
requested review from
ShogunPanda and
trivikr
and removed request for
ShogunPanda
August 3, 2026 10:31
mcollina
approved these changes
Aug 3, 2026
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
gurgunday
approved these changes
Aug 3, 2026
ShogunPanda
approved these changes
Aug 3, 2026
trivikr
approved these changes
Aug 3, 2026
aduh95
pushed a commit
that referenced
this pull request
Aug 13, 2026
Precompute a libffi call plan for each fixed signature on x86-64 System V and reuse it from the generic and SharedBuffer invokers. This avoids repeating argument-placement work for every call. Continue to use ffi_call() with libffi older than 3.7, on other ABIs, and when plan allocation fails. Signed-off-by: umuoy1 <burningdian@gmail.com> PR-URL: #64958 Fixes: #64562 Refs: libffi/libffi@3cc6beb Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #64562
Refs: libffi/libffi@3cc6beb
libffi 3.7 introduced reusable call plans that precompute argument placement. Node.js FFI functions have fixed signatures, so this change creates a plan during function preparation and reuses it for generic and SharedBuffer calls on x86-64 System V.
Other platforms, older libffi versions, and allocation failures continue to use ffi_call(). An invocation benchmark is included: it measures the call path for signatures that bypass the V8 Fast API and reach FFIFunction::Invoke(), covering a register-only and a stack-spilled call plan.
Before (ffi_call):
After (ffi_call_plan_invoke, plan reused):