FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

cli: add No-Op `--experimental-repl-await` by avivkeller · Pull Request #64986 · nodejs/node · GitHub

/ node Public

cli: add No-Op --experimental-repl-await - #64986

Closed
avivkeller wants to merge 1 commit into
nodejs:mainfrom
avivkeller:experimental-repl-await
ConversationCommits (1)ChecksFiles changed
Closed

cli: add No-Op --experimental-repl-await#64986
avivkeller wants to merge 1 commit into
nodejs:mainfrom
avivkeller:experimental-repl-await

Conversation

avivkeller commented Aug 3, 2026

Copy link
Copy Markdown
Member

cc @aduh95

Follow-up #64034

avivkeller added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v26.x PRs that should not land on the v26.x-staging branch and should not be released in v26.x. labels Aug 3, 2026

nodejs-github-bot commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/config

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. config Issues or PRs related to the config subsystem needs-ci PRs that need a full CI run. labels Aug 3, 2026

codecov Bot commented Aug 3, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.29%. Comparing base (f00fb75) to head (b032170).
⚠️ Report is 56 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #64986      +/-   ##
==========================================
+ Coverage   90.27%   90.29%   +0.02%     
==========================================
  Files         762      759       -3     
  Lines      247534   247635     +101     
  Branches    46694    46686       -8     
==========================================
+ Hits       223457   223611     +154     
+ Misses      15529    15467      -62     
- Partials     8548     8557       +9
Files with missing lines Coverage Δ
src/node_options.cc 76.67% <100.00%> (-0.08%) ⬇️

... and 68 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

aduh95 reviewed Aug 4, 2026
View reviewed changes

aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

You also need to add it back to cli.md (like is e.g. --experimental-abortcontroller etc.)

avivkeller commented Aug 4, 2026
View reviewed changes
Comment thread doc/api/cli.md Outdated
cli: add No-Op --experimental-repl-await
b032170 
Signed-off-by: Aviv Keller <me@aviv.sh>
avivkeller force-pushed the experimental-repl-await branch from 1f3cd6e to b032170 Compare August 4, 2026 19:08
aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 4, 2026
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 4, 2026

nodejs-github-bot commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75483/

nodejs-github-bot commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75548/

avivkeller added a commit that referenced this pull request Aug 15, 2026
cli: add No-Op --experimental-repl-await
8606604 
Signed-off-by: Aviv Keller <me@aviv.sh>
PR-URL: #64986
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
avivkeller closed this Aug 15, 2026

avivkeller commented Aug 15, 2026

Copy link
Copy Markdown
Member Author

Landed in 8606604

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. config Issues or PRs related to the config subsystem dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v26.x PRs that should not land on the v26.x-staging branch and should not be released in v26.x. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL