FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

http: cache maxHeaderPairs per header section by GetThatCookie · Pull Request #64988 · nodejs/node · GitHub

/ node Public

http: cache maxHeaderPairs per header section - #64988

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
GetThatCookie:pr64980_parser
Aug 22, 2026
ConversationCommits (1)ChecksFiles changed
Merged

http: cache maxHeaderPairs per header section#64988
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
GetThatCookie:pr64980_parser

Conversation

GetThatCookie commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

This PR is one of four focused changes split out of #64980 following review
feedback.

The full context, rationale, related work, benchmarks, and validation details
are documented there.

The AI-assistance disclosure in #64980 applies to this split PR as well.

nodejs-github-bot commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net
  • @nodejs/performance

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. http_parser Issues and PRs related to the HTTP Parser dependency or the http_parser binding. needs-ci PRs that need a full CI run. labels Aug 3, 2026

codecov Bot commented Aug 3, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.30%. Comparing base (f00fb75) to head (246ebc2).
⚠️ Report is 325 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #64988      +/-   ##
==========================================
+ Coverage   90.27%   90.30%   +0.02%     
==========================================
  Files         762      759       -3     
  Lines      247534   247635     +101     
  Branches    46694    46687       -7     
==========================================
+ Hits       223457   223617     +160     
+ Misses      15529    15469      -60     
- Partials     8548     8549       +1
Files with missing lines Coverage Δ
src/node_http_parser.cc 85.45% <100.00%> (+0.47%) ⬆️

... and 73 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

pimterry added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. labels Aug 4, 2026
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 4, 2026

nodejs-github-bot commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75457/

GetThatCookie requested review from pimterry and ronag August 4, 2026 21:17
This was referenced Aug 4, 2026
Closed
Closed

pimterry commented Aug 5, 2026

Copy link
Copy Markdown
Member

@GetThatCookie why the force push? Can you explain why the implementation has changed and that test code was dropped? It's helpful to provide context for reviewers when substantially changing a PR like this.

At a glance, it looks like this new code is just doing the same thing but in a more fragile less clear way, and with less testing? Presumably I'm missing something.

GetThatCookie commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

Sorry, I accidentally overwrote it with an older version.

gurgunday approved these changes Aug 5, 2026
View reviewed changes

gurgunday left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

http: cache maxHeaderPairs per header section
246ebc2 
Signed-off-by: GetThatCookie <NimmenKeks@gmx.de>

GetThatCookie commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

Missing Signed-off-by trailer...

H4ad added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 6, 2026
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 6, 2026

nodejs-github-bot commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75545/

nodejs-github-bot commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75557/

ronag requested a review from mcollina August 6, 2026 15:47
ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 6, 2026

nodejs-github-bot commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75576/

nodejs-github-bot commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75577/

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 6, 2026

nodejs-github-bot commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75588/

ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 7, 2026
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 7, 2026
ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 9, 2026
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 9, 2026

nodejs-github-bot commented Aug 9, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75679/

nodejs-github-bot commented Aug 22, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/76203/

trivikr added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 22, 2026
nodejs-github-bot merged commit 467c043 into nodejs:main Aug 22, 2026
95 of 96 checks passed

nodejs-github-bot commented Aug 22, 2026

Copy link
Copy Markdown
Collaborator

Landed in 467c043

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 22, 2026
GetThatCookie deleted the pr64980_parser branch August 24, 2026 19:21
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
http: cache maxHeaderPairs per header section
439f53f 
Signed-off-by: GetThatCookie <NimmenKeks@gmx.de>
PR-URL: #64988
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
http: cache maxHeaderPairs per header section
98e6272 
Signed-off-by: GetThatCookie <NimmenKeks@gmx.de>
PR-URL: #64988
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
github-actions Bot mentioned this pull request Aug 25, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

pimterry pimterry approved these changes
ronag ronag approved these changes
gurgunday gurgunday approved these changes
mcollina Awaiting requested review from mcollina

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. http_parser Issues and PRs related to the HTTP Parser dependency or the http_parser binding. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL