zlib: validate central directory record count - #65002
Merged
aduh95 merged 1 commit intoAug 12, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
ZIP readers trusted the EOCD record count. They did not check that the parsed headers consumed the declared central directory size. Reject archives whose count leaves directory bytes unparsed. Signed-off-by: Matteo Collina <hello@matteocollina.com>
Copy link
Copy Markdown
Contributor
|
lgtm 👍 |
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #65002 +/- ##
=======================================
Coverage 90.27% 90.27%
=======================================
Files 762 762
Lines 247515 247540 +25
Branches 46683 46690 +7
=======================================
+ Hits 223447 223478 +31
- Misses 15485 15489 +4
+ Partials 8583 8573 -10
... and 39 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
panva
approved these changes
Aug 5, 2026
aduh95
approved these changes
Aug 5, 2026
This comment was marked as outdated.
This comment was marked as outdated.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
ZIP readers trusted the EOCD record count. They did not check that the parsed headers consumed the declared central directory size. Reject archives whose count leaves directory bytes unparsed. Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #65002 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
ZIP readers trusted the EOCD record count. They did not check that the parsed headers consumed the declared central directory size. Reject archives whose count leaves directory bytes unparsed. Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #65002 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZIP readers trusted the EOCD record count without checking that the parsed headers consumed the declared central directory size. Reject archives whose record count leaves central directory bytes unparsed so all ZIP reader paths agree on the archive's entries.