zlib: reject ambiguous ZIP archive ends - #65007
Merged
nodejs-github-bot merged 1 commit intoAug 6, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
ZIP archives can contain more than one structurally plausible EOCD record. Selecting based on whether a comment reaches EOF can make the chosen central directory depend on trailing padding. Inspect all candidates in the common tail window and reject archives with multiple plausible interpretations. Signed-off-by: Matteo Collina <hello@matteocollina.com>
Copy link
Copy Markdown
Contributor
|
I like the fix since it both matches the ecosystem, but still keeps our slightly tighter strictness. There are a few cases where exotic archives would be rejected for being wrong failing closed. |
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #65007 +/- ##
==========================================
- Coverage 90.29% 90.28% -0.01%
==========================================
Files 760 762 +2
Lines 247061 247699 +638
Branches 46586 46718 +132
==========================================
+ Hits 223076 223642 +566
- Misses 15448 15489 +41
- Partials 8537 8568 +31
... and 70 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
panva
approved these changes
Aug 5, 2026
aduh95
approved these changes
Aug 5, 2026
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
ZIP archives can contain more than one structurally plausible EOCD record. Selecting based on whether a comment reaches EOF can make the chosen central directory depend on trailing padding. Inspect all candidates in the common tail window and reject archives with multiple plausible interpretations. Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #65007 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
ZIP archives can contain more than one structurally plausible EOCD record. Selecting based on whether a comment reaches EOF can make the chosen central directory depend on trailing padding. Inspect all candidates in the common tail window and reject archives with multiple plausible interpretations. Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #65007 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZIP archives can contain more than one structurally plausible EOCD record. The previous exact-comment-first search could choose a different central directory depending on trailing padding.
Scan candidates in the same tail window used for file-backed archives and reject multiple plausible interpretations. Invalid EOCD-like comment bytes remain ignored, and padded archives with one interpretation remain supported.