FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

cluster: report EADDRINUSE when a worker listens twice on the same port by islandryu · Pull Request #65020 · nodejs/node · GitHub

/ node Public

cluster: report EADDRINUSE when a worker listens twice on the same port - #65020

Open
islandryu wants to merge 2 commits into
nodejs:mainfrom
islandryu:worktree-cluster-eaddrinuse-64869
ConversationCommits (2)ChecksFiles changed
Open

cluster: report EADDRINUSE when a worker listens twice on the same port#65020
islandryu wants to merge 2 commits into
nodejs:mainfrom
islandryu:worktree-cluster-eaddrinuse-64869

Conversation

islandryu commented Aug 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes: #64869

Prevent an assertion error in child.js when a worker attempts to listen twice on the same port by detecting duplicate handle registrations in the primary process.

nodejs-github-bot added cluster Issues and PRs related to the cluster subsystem. needs-ci PRs that need a full CI run. labels Aug 4, 2026
islandryu force-pushed the worktree-cluster-eaddrinuse-64869 branch from bd5c12f to ed8f6a3 Compare August 7, 2026 14:29
islandryu marked this pull request as ready for review August 7, 2026 15:22

codecov Bot commented Aug 7, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.14%. Comparing base (facd71e) to head (d095f6e).
⚠️ Report is 1307 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #65020      +/-   ##
==========================================
+ Coverage   90.04%   90.14%   +0.10%     
==========================================
  Files         713      751      +38     
  Lines      224950   252648   +27698     
  Branches    42530    47542    +5012     
==========================================
+ Hits       202548   227754   +25206     
- Misses      14188    16182    +1994     
- Partials     8214     8712     +498
Files with missing lines Coverage Δ
lib/internal/cluster/primary.js 94.75% <100.00%> (+0.14%) ⬆️

... and 461 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

PickBas reviewed Aug 10, 2026
View reviewed changes
Comment thread test/sequential/test-cluster-listen-twice-same-port.js

PickBas Aug 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I have a suggestion for the test: it passes on an unpatched build under SCHED_RR (the POSIX default), so it wouldn't catch a regression on Linux/macOS. The PR fixes behavior with SCHED_NONE, so could the tests cover both SCHED_RR and SCHED_NONE policies regardless of the OS?

islandryu Aug 23, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Good catch! I've covered both policies.

StefanStojanovic added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 25, 2026
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 25, 2026

nodejs-github-bot commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/76474/

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

StefanStojanovic StefanStojanovic approved these changes
+1 more reviewer
PickBas PickBas left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cluster Issues and PRs related to the cluster subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cluster: ERR_INTERNAL_ASSERTION when a worker listens twice on the same host:port (Windows, regression from #60141)

4 participants

Back | FazBrowse Home | New Git URL