sqlite: clear SQLTagStore bindings - #65041
Merged
nodejs-github-bot merged 1 commit intoAug 7, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
SQLTagStore reused cached statements without clearing values bound by a previous execution. Clear bindings before binding new values and reject parameters that do not correspond to template substitutions. Signed-off-by: Matteo Collina <hello@matteocollina.com>
mcollina
force-pushed
the
fix-sqlite-tagstore-bindings
branch
from
35ab44c to
78f82ca
Compare
August 5, 2026 09:41
Copy link
Copy Markdown
Codecov Report❌ Patch coverage is 85.18519% with 4 lines in your changes missing coverage. Please review.
@@ Coverage Diff @@
## main #65041 +/- ##
=======================================
Coverage 90.30% 90.30%
=======================================
Files 759 759
Lines 247597 247586 -11
Branches 46679 46673 -6
=======================================
+ Hits 223591 223592 +1
+ Misses 15469 15459 -10
+ Partials 8537 8535 -2
... and 27 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
Renegade334
approved these changes
Aug 5, 2026
Comment thread
src/node_sqlite.cc
Comment on lines
+3423
to
+3430
| uint32_t n_params = args.Length() - 1; | ||
| int param_count = sqlite3_bind_parameter_count(stmt->statement_); | ||
| if (param_count != static_cast<int>(n_params)) { | ||
| THROW_ERR_INVALID_ARG_VALUE( | ||
| env, | ||
| "SQLite parameters must be bound using template literal placeholders."); | ||
| return false; | ||
| } |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Nice.
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
trivikr
approved these changes
Aug 6, 2026
aduh95
pushed a commit
that referenced
this pull request
Aug 13, 2026
SQLTagStore reused cached statements without clearing values bound by a previous execution. Clear bindings before binding new values and reject parameters that do not correspond to template substitutions. Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #65041 Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
SQLTagStore reused cached statements without clearing values bound by a previous execution. Clear bindings before binding new values and reject parameters that do not correspond to template substitutions. Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #65041 Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQLTagStore reused cached statements without clearing values bound by a previous execution. Clear bindings before binding new values and reject parameters that do not correspond to template substitutions.