FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

typings: add internal_only_v8 binding types by HoonDongKang · Pull Request #65071 · nodejs/node · GitHub

/ node Public

typings: add internal_only_v8 binding types - #65071

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
HoonDongKang:typings-internal-only-v8-binding
Aug 14, 2026
Merged

typings: add internal_only_v8 binding types#65071
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
HoonDongKang:typings-internal-only-v8-binding

Conversation

Copy link
Copy Markdown
Contributor

Add typings for the internal_only_v8 internal binding.

Changes:

  • Added typings/internalBinding/internal_only_v8.d.ts
  • Added internal_only_v8 to InternalBindingMap
  • Typed queryObjects()

Add an InternalOnlyV8Binding declaration for
internalBinding('internal_only_v8') and wire it into
InternalBindingMap.

Signed-off-by: HoonDongKang <d159123@naver.com>
HoonDongKang force-pushed the typings-internal-only-v8-binding branch from d25d4c0 to 6f39e0e Compare August 6, 2026 07:18
Signed-off-by: HoonDongKang <d159123@naver.com>
daeyeon added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 11, 2026
nodejs-github-bot merged commit 5e7bd32 into nodejs:main Aug 14, 2026
26 checks passed

Copy link
Copy Markdown
Collaborator

Landed in 5e7bd32

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 14, 2026
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
Add an InternalOnlyV8Binding declaration for
internalBinding('internal_only_v8') and wire it into
InternalBindingMap.

Signed-off-by: HoonDongKang <d159123@naver.com>
PR-URL: #65071
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
Add an InternalOnlyV8Binding declaration for
internalBinding('internal_only_v8') and wire it into
InternalBindingMap.

Signed-off-by: HoonDongKang <d159123@naver.com>
PR-URL: #65071
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. typings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL