crypto: add mgf1Hash for RSA-OAEP - #65073
Closed
adamjmcgrath wants to merge 3 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
adamjmcgrath
force-pushed
the
add-mgf1hash
branch
from
425b745 to
2da33e7
Compare
August 6, 2026 08:25
adamjmcgrath
marked this pull request as ready for review
August 6, 2026 09:56
panva
approved these changes
Aug 6, 2026
panva
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thank you Adam
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Signed-off-by: Adam Mcgrath <adam.mcgrath@okta.com>
Signed-off-by: Adam Mcgrath <adam.mcgrath@okta.com>
Copy link
Copy Markdown
Codecov Report❌ Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.
@@ Coverage Diff @@
## main #65073 +/- ##
==========================================
- Coverage 90.31% 90.31% -0.01%
==========================================
Files 759 759
Lines 248258 248269 +11
Branches 46854 46856 +2
==========================================
- Hits 224225 224220 -5
+ Misses 15465 15461 -4
- Partials 8568 8588 +20
... and 30 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
adamjmcgrath
force-pushed
the
add-mgf1hash
branch
from
58ff494 to
0a04e0b
Compare
August 6, 2026 13:40
panva
approved these changes
Aug 6, 2026
This comment was marked as outdated.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Commit Queue failed- Loading data for nodejs/node/pull/65073 ✔ Done loading data for nodejs/node/pull/65073 ----------------------------------- PR info ------------------------------------ Title crypto: add mgf1Hash for RSA-OAEP (#65073) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch adamjmcgrath:add-mgf1hash -> nodejs:main Labels crypto, test, author ready, needs-ci, commit-queue, commit-queue-squash, lts-watch-v24.x Commits 3 - crypto: add mgf1Hash for RSA-OAEP - crypto: fix lint and tests - test: update test Committers 1 - Adam Mcgrath <adam.mcgrath@okta.com> PR-URL: https://github.com/nodejs/node/pull/65073 Reviewed-By: Filip Skokan <panva.ip@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/65073 Reviewed-By: Filip Skokan <panva.ip@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 06 Aug 2026 08:23:40 GMT ✔ Approvals: 1 ✔ - Filip Skokan (@panva) (TSC): https://github.com/nodejs/node/pull/65073#pullrequestreview-4875510214 ✘ This PR needs to wait 82 more hours to land (or 0 minutes if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2026-08-06T17:55:09Z: https://ci.nodejs.org/job/node-test-pull-request/75581/ - Querying data for job/node-test-pull-request/75581/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /Users/avivkeller/Documents/projects/nodejs/node/.ncu/nodejs/node/actions/runs/ |
Sorry, something went wrong.
avivkeller
approved these changes
Aug 9, 2026
avivkeller
pushed a commit
that referenced
this pull request
Aug 9, 2026
Signed-off-by: Adam Mcgrath <adam.mcgrath@okta.com> PR-URL: #65073 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95
pushed a commit
that referenced
this pull request
Aug 13, 2026
Signed-off-by: Adam Mcgrath <adam.mcgrath@okta.com> PR-URL: #65073 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
Signed-off-by: Adam Mcgrath <adam.mcgrath@okta.com> PR-URL: #65073 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Aviv Keller <me@aviv.sh>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
crypto.publicEncrypt() and crypto.privateDecrypt() expose only the oaepHash option, which sets both the OAEP message digest and the MGF1 hash.
As a result, Node cannot decrypt (or produce) an RSA-OAEP ciphertext where the OAEP digest and the MGF1 hash differ — e.g. OAEP digest = SHA-256, MGF1 = SHA-1.
OpenSSL exposes the two digests independently via EVP_PKEY_CTX_set_rsa_oaep_md and EVP_PKEY_CTX_set_rsa_mgf1_md so this PR adds an mgf1Hash option that, when set, calls EVP_PKEY_CTX_set_rsa_mgf1_md independently of oaepHash.
This is required to implement http://www.w3.org/2001/04/xmlenc#rsa-oaep-mgf1p where the message digest can be configurable (e.g. SHA-256) but the mask generation function must be fixed to SHA-1.