domain: runtime-deprecate the module - #65074
Open
mcollina wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
mcollina
force-pushed
the
domain-runtime-deprecation
branch
from
a0a1112 to
b375429
Compare
August 6, 2026 10:29
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #65074 +/- ##
==========================================
+ Coverage 90.27% 90.30% +0.03%
==========================================
Files 762 759 -3
Lines 247524 248264 +740
Branches 46693 46850 +157
==========================================
+ Hits 223451 224200 +749
+ Misses 15494 15471 -23
- Partials 8579 8593 +14
... and 70 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
Promote DEP0032 from a documentation-only deprecation to a runtime deprecation. Loading the `node:domain` module now emits a DeprecationWarning with code DEP0032, and the docs are updated to reflect the Runtime deprecation type. Signed-off-by: Matteo Collina <hello@matteocollina.com>
mcollina
force-pushed
the
domain-runtime-deprecation
branch
from
b375429 to
6ae58dd
Compare
August 6, 2026 12:59
Comment thread
doc/api/deprecations.md
|
|
||
| The [`domain`][] module is deprecated and should not be used. |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
is there are "equivalent" api that they can use. as my knowledge there aren't any 1:1 api for that.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
none, this was a bad idea.
Sorry, something went wrong.
avivkeller
approved these changes
Aug 7, 2026
marco-ippolito
approved these changes
Aug 13, 2026
anonrig
approved these changes
Aug 19, 2026
jasnell
approved these changes
Aug 20, 2026
jasnell
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
It's about time!
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promote DEP0032 (node:domain module) from a documentation-only deprecation to a runtime deprecation.
Fixes #10843