FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: document close() error when in a sqlite callback by trivikr · Pull Request #65090 · nodejs/node · GitHub

/ node Public

doc: document close() error when in a sqlite callback - #65090

Merged
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
trivikr:doc-sqlite-close-during-callback
Aug 11, 2026
ConversationCommits (3)ChecksFiles changed
Merged

doc: document close() error when in a sqlite callback#65090
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
trivikr:doc-sqlite-close-during-callback

Conversation

trivikr commented Aug 6, 2026

Copy link
Copy Markdown
Member

Refs: #64743

nodejs-github-bot commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/sqlite

trivikr requested a review from mcollina August 6, 2026 17:58
nodejs-github-bot added doc Issues and PRs related to the documentations. sqlite Issues and PRs related to the SQLite subsystem. labels Aug 6, 2026
trivikr force-pushed the doc-sqlite-close-during-callback branch 2 times, most recently from 6437b89 to ac3cec4 Compare August 7, 2026 03:32
Hardanish-Singh reviewed Aug 7, 2026
View reviewed changes
Comment thread doc/api/sqlite.md Outdated
Hardanish-Singh reviewed Aug 7, 2026
View reviewed changes

Hardanish-Singh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

trivikr marked this pull request as draft August 8, 2026 18:41

This comment was marked as outdated.

Sign in to view
trivikr mentioned this pull request Aug 8, 2026
Merged
trivikr force-pushed the doc-sqlite-close-during-callback branch from f76ffe0 to ec4a541 Compare August 9, 2026 23:31
trivikr marked this pull request as ready for review August 9, 2026 23:31
araujogui approved these changes Aug 10, 2026
View reviewed changes

araujogui left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

trivikr requested a review from Renegade334 August 10, 2026 20:44
trivikr added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 11, 2026
nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 11, 2026

nodejs-github-bot commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/65090
✔  Done loading data for nodejs/node/pull/65090
----------------------------------- PR info ------------------------------------
Title      doc: document close() error when in a sqlite callback (#65090)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     trivikr:doc-sqlite-close-during-callback -> nodejs:main
Labels     doc, commit-queue, commit-queue-squash, sqlite
Commits    3
 - doc: document close() error when in a sqlite callback
 - fixup! doc: use "such as" instead of "for example from"
 - fixup! doc: use ref for ERR_INVALID_STATE
Committers 1
 - Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
PR-URL: https://github.com/nodejs/node/pull/65090
Refs: https://github.com/nodejs/node/pull/64743
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/65090
Refs: https://github.com/nodejs/node/pull/64743
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 06 Aug 2026 17:56:09 GMT
   ✔  Approvals: 1
   ✔  - René (@Renegade334): https://github.com/nodejs/node/pull/65090#pullrequestreview-4901119177
   ✘  This PR needs to wait 63 more hours to land (or 0 minutes if there is one more approval)
   ✘  2 GitHub CI job(s) cancelled:
   ✘    - lint-readme: CANCELLED (https://github.com/nodejs/node/actions/runs/31342093694/job/93317443981)
   ✘    - lint-pr-url: CANCELLED (https://github.com/nodejs/node/actions/runs/31342093694/job/93317444012)
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/31454646415

trivikr removed commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Aug 11, 2026
trivikr added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 11, 2026
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 11, 2026
nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Aug 11, 2026

nodejs-github-bot commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/65090
✔  Done loading data for nodejs/node/pull/65090
----------------------------------- PR info ------------------------------------
Title      doc: document close() error when in a sqlite callback (#65090)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     trivikr:doc-sqlite-close-during-callback -> nodejs:main
Labels     doc, commit-queue, commit-queue-squash, sqlite
Commits    3
 - doc: document close() error when in a sqlite callback
 - fixup! doc: use "such as" instead of "for example from"
 - fixup! doc: use ref for ERR_INVALID_STATE
Committers 1
 - Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
PR-URL: https://github.com/nodejs/node/pull/65090
Refs: https://github.com/nodejs/node/pull/64743
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/65090
Refs: https://github.com/nodejs/node/pull/64743
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 06 Aug 2026 17:56:09 GMT
   ✔  Approvals: 2
   ✔  - René (@Renegade334): https://github.com/nodejs/node/pull/65090#pullrequestreview-4901119177
   ✔  - Edy Silva (@geeksilva97): https://github.com/nodejs/node/pull/65090#pullrequestreview-4908558938
   ✘  2 GitHub CI job(s) cancelled:
   ✘    - lint-readme: CANCELLED (https://github.com/nodejs/node/actions/runs/31342093694/job/93317443981)
   ✘    - lint-pr-url: CANCELLED (https://github.com/nodejs/node/actions/runs/31342093694/job/93317444012)
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/31515557655

trivikr added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Aug 11, 2026
nodejs-github-bot merged commit 7d712ae into nodejs:main Aug 11, 2026
62 of 64 checks passed

nodejs-github-bot commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

Landed in 7d712ae

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 11, 2026
aduh95 pushed a commit that referenced this pull request Aug 13, 2026
doc: document close() error when in a sqlite callback
b14f900 
Signed-off-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com>
PR-URL: #65090
Refs: #64743
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
trivikr deleted the doc-sqlite-close-during-callback branch August 16, 2026 16:01
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
doc: document close() error when in a sqlite callback
43f1dc0 
Signed-off-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com>
PR-URL: #65090
Refs: #64743
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
github-actions Bot mentioned this pull request Aug 25, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Renegade334 Renegade334 approved these changes
geeksilva97 geeksilva97 approved these changes
mcollina Awaiting requested review from mcollina
+2 more reviewers
Hardanish-Singh Hardanish-Singh left review comments
araujogui araujogui approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations. sqlite Issues and PRs related to the SQLite subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL