process: validate resource stats array offsets - #65098
Closed
Archkon wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #65098 +/- ##
=======================================
Coverage 90.31% 90.31%
=======================================
Files 759 759
Lines 248299 248289 -10
Branches 46854 46858 +4
=======================================
- Hits 224251 224243 -8
- Misses 15468 15469 +1
+ Partials 8580 8577 -3
... and 33 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
Renegade334
requested changes
Aug 7, 2026
Renegade334
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
We define the only ABVs that are ever passed to these bindings. A simple CHECK_EQ(arr->ByteOffset(), 0) is all that's needed here.
Sorry, something went wrong.
Assert that the internally allocated Float64Array views used by CPU, thread CPU, memory, and resource statistics have zero byte offsets. Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
This comment was marked as spam.
Renegade334
approved these changes
Aug 7, 2026
This comment was marked as outdated.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Commit Queue failed- Loading data for nodejs/node/pull/65098 ✔ Done loading data for nodejs/node/pull/65098 ----------------------------------- PR info ------------------------------------ Title process: validate resource stats array offsets (#65098) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch Archkon:process6 -> nodejs:main Labels c++, author ready, needs-ci, commit-queue Commits 1 - process: validate resource stats array offsets Committers 1 - Archkon <180910180+Archkon@users.noreply.github.com> PR-URL: https://github.com/nodejs/node/pull/65098 Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/65098 Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 07 Aug 2026 07:58:58 GMT ✔ Approvals: 1 ✔ - René (@Renegade334): https://github.com/nodejs/node/pull/65098#pullrequestreview-4882184408 ✘ This PR needs to wait 106 more hours to land (or 0 minutes if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2026-08-07T12:47:06Z: https://ci.nodejs.org/job/node-test-pull-request/75613/ - Querying data for job/node-test-pull-request/75613/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /Users/avivkeller/Documents/projects/nodejs/node/.ncu/nodejs/node/actions/runs/ |
Sorry, something went wrong.
avivkeller
approved these changes
Aug 9, 2026
avivkeller
pushed a commit
that referenced
this pull request
Aug 9, 2026
Assert that the internally allocated Float64Array views used by CPU, thread CPU, memory, and resource statistics have zero byte offsets. Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com> PR-URL: #65098 Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95
pushed a commit
that referenced
this pull request
Aug 13, 2026
Assert that the internally allocated Float64Array views used by CPU, thread CPU, memory, and resource statistics have zero byte offsets. Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com> PR-URL: #65098 Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
Assert that the internally allocated Float64Array views used by CPU, thread CPU, memory, and resource statistics have zero byte offsets. Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com> PR-URL: #65098 Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Aviv Keller <me@aviv.sh>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assert that the internally allocated Float64Array views used by CPU, thread CPU, memory, and resource statistics have zero byte offsets.