FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: add v8::Local specialization for MaybeStackBuffer by jasnell · Pull Request #65159 · nodejs/node · GitHub

/ node Public

src: add v8::Local specialization for MaybeStackBuffer - #65159

Closed
jasnell wants to merge 1 commit into
nodejs:mainfrom
jasnell:jasnell/maybestackbuffer-v8-local
ConversationCommits (1)ChecksFiles changed
Closed

src: add v8::Local specialization for MaybeStackBuffer#65159
jasnell wants to merge 1 commit into
nodejs:mainfrom
jasnell:jasnell/maybestackbuffer-v8-local

Conversation

jasnell commented Aug 9, 2026

Copy link
Copy Markdown
Member

Long-term itch. Per v8 rules, we're not supposed to be heap allocating v8::Local's; instead we're supposed to be using v8::LocalVector. Create a specialization of MaybeStackBuffer that uses either a stack array of v8::Locals or v8::LocalVector with some additional utility improvements.

nodejs-github-bot commented Aug 9, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/http2
  • @nodejs/net

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Aug 9, 2026
jasnell requested a review from addaleax August 9, 2026 04:36
jasnell force-pushed the jasnell/maybestackbuffer-v8-local branch 4 times, most recently from 2b1fac0 to f819d7c Compare August 9, 2026 05:29

This comment was marked as outdated.

Sign in to view

codecov Bot commented Aug 9, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 82.55814% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.31%. Comparing base (2929417) to head (823d73d).
⚠️ Report is 32 commits behind head on main.

Files with missing lines Patch % Lines
src/util-inl.h 72.72% 3 Missing and 3 partials ⚠️
src/js_udp_wrap.cc 0.00% 4 Missing ⚠️
src/util.h 89.28% 0 Missing and 3 partials ⚠️
src/node_dir.cc 66.66% 0 Missing and 1 partial ⚠️
src/node_env_var.cc 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #65159      +/-   ##
==========================================
- Coverage   90.34%   90.31%   -0.04%     
==========================================
  Files         751      751              
  Lines      250330   250374      +44     
  Branches    47321    47318       -3     
==========================================
- Hits       226171   226116      -55     
- Misses      15557    15619      +62     
- Partials     8602     8639      +37
Files with missing lines Coverage Δ
src/api/callback.cc 83.17% <100.00%> (ø)
src/cares_wrap.cc 63.09% <100.00%> (ø)
src/crypto/crypto_tls.cc 78.77% <100.00%> (-0.02%) ⬇️
src/js_stream.cc 74.43% <100.00%> (-0.38%) ⬇️
src/node_http2.cc 81.80% <100.00%> (+<0.01%) ⬆️
src/node_messaging.cc 82.77% <100.00%> (-0.18%) ⬇️
src/node_messaging.h 63.15% <ø> (ø)
src/node_v8.cc 87.86% <100.00%> (ø)
src/spawn_sync.cc 68.88% <100.00%> (-0.05%) ⬇️
src/node_dir.cc 70.78% <66.66%> (-0.30%) ⬇️
... and 4 more

... and 34 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This comment was marked as resolved.

Sign in to view
jasnell force-pushed the jasnell/maybestackbuffer-v8-local branch from f819d7c to abf8c83 Compare August 9, 2026 15:33

This comment was marked as outdated.

Sign in to view
jasnell requested a review from joyeecheung August 10, 2026 13:58

This comment was marked as outdated.

Sign in to view
jasnell requested a review from mcollina August 12, 2026 18:07
jasnell force-pushed the jasnell/maybestackbuffer-v8-local branch from abf8c83 to a052553 Compare August 12, 2026 18:46

This comment was marked as outdated.

Sign in to view
jasnell marked this pull request as draft August 12, 2026 19:43

This comment was marked as resolved.

Sign in to view
jasnell marked this pull request as ready for review August 14, 2026 02:53
jasnell force-pushed the jasnell/maybestackbuffer-v8-local branch from a052553 to 996535d Compare August 14, 2026 02:53
jasnell requested a review from Qard August 14, 2026 02:53
src: add v8::Local specialization for MaybeStackBuffer
823d73d 
Long-term itch. Per v8 rules, we're not supposed to be
heap allocating v8::Local's; instead we're supposed to
be using v8::LocalVector. Create a specialization of
MaybeStackBuffer that uses either a stack array of
v8::Locals or v8::LocalVector with some additional
utility improvements.

Signed-off-by: James M Snell <jasnell@gmail.com>
jasnell force-pushed the jasnell/maybestackbuffer-v8-local branch from 996535d to 823d73d Compare August 15, 2026 18:13
jasnell added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 17, 2026

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

nodejs-github-bot commented Aug 17, 2026 •
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75940/ 💚

jasnell commented Aug 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

CI status is being misreported due to the github outage (apparently)

jasnell added a commit that referenced this pull request Aug 17, 2026
src: add v8::Local specialization for MaybeStackBuffer
6456418 
Long-term itch. Per v8 rules, we're not supposed to be
heap allocating v8::Local's; instead we're supposed to
be using v8::LocalVector. Create a specialization of
MaybeStackBuffer that uses either a stack array of
v8::Locals or v8::LocalVector with some additional
utility improvements.

Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #65159
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>

jasnell commented Aug 17, 2026

Copy link
Copy Markdown
Member Author

Landed in 6456418

jasnell closed this Aug 17, 2026
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
src: add v8::Local specialization for MaybeStackBuffer
18134c1 
Long-term itch. Per v8 rules, we're not supposed to be
heap allocating v8::Local's; instead we're supposed to
be using v8::LocalVector. Create a specialization of
MaybeStackBuffer that uses either a stack array of
v8::Locals or v8::LocalVector with some additional
utility improvements.

Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #65159
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
src: add v8::Local specialization for MaybeStackBuffer
613be79 
Long-term itch. Per v8 rules, we're not supposed to be
heap allocating v8::Local's; instead we're supposed to
be using v8::LocalVector. Create a specialization of
MaybeStackBuffer that uses either a stack array of
v8::Locals or v8::LocalVector with some additional
utility improvements.

Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #65159
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
github-actions Bot mentioned this pull request Aug 25, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Qard Qard approved these changes
addaleax Awaiting requested review from addaleax
joyeecheung Awaiting requested review from joyeecheung
mcollina Awaiting requested review from mcollina

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL