FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: make env variables consistent in cron jobs by aduh95 · Pull Request #65168 · nodejs/node · GitHub

/ node Public

tools: make env variables consistent in cron jobs - #65168

Merged
nodejs-github-bot merged 6 commits into
nodejs:mainfrom
aduh95:consistent-cron-envs
Aug 20, 2026
ConversationCommits (6)ChecksFiles changed
Merged

tools: make env variables consistent in cron jobs#65168
nodejs-github-bot merged 6 commits into
nodejs:mainfrom
aduh95:consistent-cron-envs

Conversation

aduh95 commented Aug 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Pass -R/--repo explicitly instead of an implicit use of GH_REPO or let the tool figure out based on the local repo
  • Prefer GH_TOKEN, since that's what gh checks first according to https://cli.github.com/manual/gh_help_environment
  • Prefer github.token over secrets.GITHUB_TOKEN to help avoid confusing it with secrets.GH_USER_TOKEN=
  • Document secrets used in auto-start-ci.yml, remove references to secrets.GH_USER_TOKEN (add permissions meeting the ones we use for CQ filtering PRs)
  • Do not pass owner and repository as argv for commit-queue.sh, it already expects to find e.g. GITHUB_SERVER_URL in the env, it's simpler for it to also expect GITHUB_REPOSITORY to be defined.
  • Move git config call to the workflow so a human running the script locally doesn't accidentally impersonate the bot.

nodejs-github-bot commented Aug 9, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

nodejs-github-bot added meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Aug 9, 2026
aduh95 force-pushed the consistent-cron-envs branch 5 times, most recently from 6ef5a74 to 3fcf56f Compare August 10, 2026 13:41
aduh95 requested a review from panva August 10, 2026 16:20

panva commented Aug 10, 2026

Copy link
Copy Markdown
Member

There's a permissions smoking gun in there somewhere. Sorry I don't have the time to look closely at the moment.

aduh95 commented Aug 10, 2026

Copy link
Copy Markdown
Contributor Author

There's a permissions smoking gun in there somewhere. Sorry I don't have the time to look closely at the moment.

I'm not touching the permissions though

panva commented Aug 10, 2026

Copy link
Copy Markdown
Member

I'm not touching the permissions though

But there is a user change in auto-start-ci.yml, isn't there?

panva reviewed Aug 10, 2026
View reviewed changes
Comment thread .github/workflows/commit-queue.yml
panva reviewed Aug 10, 2026
View reviewed changes
Comment thread .github/workflows/auto-start-ci.yml Outdated

panva commented Aug 10, 2026

Copy link
Copy Markdown
Member

Is use of ?: intentional over :??

aduh95 force-pushed the consistent-cron-envs branch from 3a4eccd to e775846 Compare August 11, 2026 13:47
aduh95 force-pushed the consistent-cron-envs branch from e775846 to efed148 Compare August 12, 2026 16:02
aduh95 commented Aug 20, 2026
View reviewed changes
Comment thread doc/contributing/commit-queue.md Outdated
aduh95 commented Aug 20, 2026
View reviewed changes
Comment thread doc/contributing/commit-queue.md Outdated
aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 20, 2026
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 20, 2026
nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Aug 20, 2026

nodejs-github-bot commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/65168
✔  Done loading data for nodejs/node/pull/65168
----------------------------------- PR info ------------------------------------
Title      tools: make env variables consistent in cron jobs (#65168)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     aduh95:consistent-cron-envs -> nodejs:main
Labels     meta, tools, author ready, commit-queue
Commits    6
 - tools: make env variables consistent in cron jobs
 - fixup! tools: make env variables consistent in cron jobs
 - squash! use same permissions as CQ
 - squash! Apply suggestion from @panva
 - squash! not early stage anymore
 - squash! not early stages anymore
Committers 2
 - Antoine du Hamel <duhamelantoine1995@gmail.com>
 - GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/65168
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/65168
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 09 Aug 2026 18:21:21 GMT
   ✔  Approvals: 1
   ✔  - Filip Skokan (@panva) (TSC): https://github.com/nodejs/node/pull/65168#pullrequestreview-4983148316
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 65168
From https://github.com/nodejs/node
 * branch                  refs/pull/65168/merge -> FETCH_HEAD
✔  Fetched commits as 58d58a47e3f8..1316c0d3ee44
--------------------------------------------------------------------------------
[main 6b25dfdc6b] tools: make env variables consistent in cron jobs
 Author: Antoine du Hamel <duhamelantoine1995@gmail.com>
 Date: Sun Aug 9 20:13:26 2026 +0200
 4 files changed, 26 insertions(+), 37 deletions(-)
[main 977da716bc] fixup! tools: make env variables consistent in cron jobs
 Author: Antoine du Hamel <duhamelantoine1995@gmail.com>
 Date: Mon Aug 10 23:15:32 2026 +0200
 3 files changed, 9 insertions(+), 157 deletions(-)
[main 76d31e5981] squash! use same permissions as CQ
 Author: Antoine du Hamel <duhamelantoine1995@gmail.com>
 Date: Mon Aug 10 21:18:11 2026 +0200
 1 file changed, 2 insertions(+)
[main d766fff13e] squash! Apply suggestion from @panva
 Author: Antoine du Hamel <duhamelantoine1995@gmail.com>
 Date: Mon Aug 10 23:15:58 2026 +0200
 1 file changed, 1 insertion(+), 1 deletion(-)
[main 162af24468] squash! not early stage anymore
 Author: Antoine du Hamel <duhamelantoine1995@gmail.com>
 Date: Thu Aug 20 15:19:14 2026 +0200
 1 file changed, 1 insertion(+), 1 deletion(-)
[main a0b2e90ff1] squash! not early stages anymore
 Author: Antoine du Hamel <duhamelantoine1995@gmail.com>
 Date: Thu Aug 20 15:19:49 2026 +0200
 1 file changed, 2 deletions(-)
   ✔  Patches applied
Please run the following commands to complete landing

$ git rebase origin/main --no-keep-empty -i -x "git node land --amend" --autosquash

$ git node land --continue
https://github.com/nodejs/node/actions/runs/32387611571

aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Aug 20, 2026
nodejs-github-bot merged commit 12eb296 into nodejs:main Aug 20, 2026
34 checks passed

nodejs-github-bot commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

Landed in 12eb296

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 20, 2026
aduh95 deleted the consistent-cron-envs branch August 20, 2026 19:58
aduh95 added a commit that referenced this pull request Aug 25, 2026
tools: make env variables consistent in cron jobs
3ec5133 
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #65168
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
aduh95 added a commit that referenced this pull request Aug 25, 2026
tools: make env variables consistent in cron jobs
41edd2f 
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #65168
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
github-actions Bot mentioned this pull request Aug 25, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

panva panva approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL