FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: use the read-only token when filtering PRs in CQ by aduh95 · Pull Request #65169 · nodejs/node · GitHub

/ node Public

tools: use the read-only token when filtering PRs in CQ - #65169

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:read-only-cq-filter
Aug 9, 2026
Merged

tools: use the read-only token when filtering PRs in CQ#65169
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:read-only-cq-filter

Conversation

aduh95 commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

To follow the principle of least access, and to maybe avoid exceeding GH API rate limits (e.g. https://github.com/nodejs/node/actions/runs/31326707444/job/93278146885).

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Aug 9, 2026

Copy link
Copy Markdown
Member

maybe avoid exceeding GH API rate limits

FWIW using a GitHub app over a GitHub Bot Token has increased API limits, I think

panva added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 9, 2026

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @panva. Please 👍 to approve.

MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 9, 2026
nodejs-github-bot merged commit 2b7766e into nodejs:main Aug 9, 2026
25 checks passed

Copy link
Copy Markdown
Collaborator

Landed in 2b7766e

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 9, 2026

panva commented Aug 9, 2026
edited
Loading

Copy link
Copy Markdown
Member

💣 https://github.com/nodejs/node/actions/runs/31332331984/job/93292464842 (disabled the workflow for now)

aduh95 deleted the read-only-cq-filter branch August 9, 2026 19:52
aduh95 added a commit that referenced this pull request Aug 10, 2026
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #65192
Refs: #65169
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
aduh95 added a commit that referenced this pull request Aug 13, 2026
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #65169
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
aduh95 added a commit that referenced this pull request Aug 13, 2026
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #65192
Refs: #65169
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
aduh95 added a commit that referenced this pull request Aug 25, 2026
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #65169
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
aduh95 added a commit that referenced this pull request Aug 25, 2026
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #65192
Refs: #65169
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL