Review requested:

• @nodejs/ffi

Codecov Report

❌ Patch coverage is 48.97959% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.32%. Comparing base (a576f1c) to head (4c9023c).
⚠️ Report is 3 commits behind head on main.

@@            Coverage Diff             @@
##             main   #65184      +/-   ##
==========================================
+ Coverage   90.30%   90.32%   +0.01%     
==========================================
  Files         760      760              
  Lines      248526   248530       +4     
  Branches    46886    46895       +9     
==========================================
+ Hits       224439   224478      +39     
+ Misses      15515    15465      -50     
- Partials     8572     8587      +15     

... and 29 files with indirect coverage changes

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

CI: https://ci.nodejs.org/job/node-test-pull-request/75753/

Converted to draft since test-ffi-dynamic-library is failing in https://ci.nodejs.org/job/node-test-commit-aix/64326/

not ok 3 ffi/test-ffi-dynamic-library
  ---
  duration_ms: 800.27300
  severity: fail
  exitcode: 1
  stack: |-
    Test failure: 'FFI functions are not constructible'
    Location: test/ffi/test-ffi-dynamic-library.js:70:1
    AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
    
    true !== false
    
        at TestContext.<anonymous> (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-power9/test/ffi/test-ffi-dynamic-library.js:77:12)
        at Test.runInAsyncScope (node:async_hooks:227:14)
        at Test.run (node:internal/test_runner/test:1397:25)
        at Test.processPendingSubtests (node:internal/test_runner/test:969:18)
        at Test.postRun (node:internal/test_runner/test:1537:19)
        at Test.run (node:internal/test_runner/test:1462:12)
        at process.processTicksAndRejections (node:internal/process/task_queues:104:5)
        at async Test.processPendingSubtests (node:internal/test_runner/test:969:7) {
      generatedMessage: true,
      code: 'ERR_ASSERTION',
      actual: true,
      expected: false,
      operator: 'strictEqual',
      diff: 'simple'
    }
    
    (node:31457608) ExperimentalWarning: FFI is an experimental feature and might change at any time
    (Use `node --trace-warnings ...` to show where the warning was created)
  ...

The AIX failure occurred because AIX uses neither of the JavaScript wrapper paths updated in the original commit.

AIX/PowerPC is excluded from the Fast API path because there is no PPC64 big-endian trampoline emitter. The shared-buffer path is also disabled on big-endian platforms. Consequently, AIX falls back to the generic native function created with v8::Function::New().

Function::New() defaults to ConstructorBehavior::kAllow, so the fallback function had its own prototype and remained constructible. Since it had no Fast API or shared-buffer metadata, it was returned without a JavaScript wrapper.

I amended the commit to create the generic fallback and shared-buffer slow-path functions with ConstructorBehavior::kThrow. The concise-method changes still ensure that JavaScript wrappers are non-constructible, while the C++ change covers native fallback paths such as AIX.

CI: https://ci.nodejs.org/job/node-test-pull-request/75766/

Landed in 8f6c69f