crypto: fix missing error checks on ASN1_STRING_to_UTF8() - #65200
Merged
nodejs-github-bot merged 1 commit intoAug 20, 2026
Merged
crypto: fix missing error checks on ASN1_STRING_to_UTF8()#65200nodejs-github-bot merged 1 commit into
nodejs-github-bot merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This function returns a negative error code on error. When it does so, the `value_str` pointer will remain uninitialized and cause a crash later on when it is freed by OPENSSL_free(). Even if it wouldn't crash there, it still fails to signal the error and an empty string may be propagated to the callers. The check also mirrors the other one in the same file. Signed-off-by: ndossche <nora.dossche@ugent.be>
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
anonrig
approved these changes
Aug 10, 2026
panva
approved these changes
Aug 10, 2026
This comment was marked as outdated.
This comment was marked as resolved.
daeyeon
approved these changes
Aug 11, 2026
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
This function returns a negative error code on error. When it does so, the `value_str` pointer will remain uninitialized and cause a crash later on when it is freed by OPENSSL_free(). Even if it wouldn't crash there, it still fails to signal the error and an empty string may be propagated to the callers. The check also mirrors the other one in the same file. Signed-off-by: ndossche <nora.dossche@ugent.be> PR-URL: #65200 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
This function returns a negative error code on error. When it does so, the `value_str` pointer will remain uninitialized and cause a crash later on when it is freed by OPENSSL_free(). Even if it wouldn't crash there, it still fails to signal the error and an empty string may be propagated to the callers. The check also mirrors the other one in the same file. Signed-off-by: ndossche <nora.dossche@ugent.be> PR-URL: #65200 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function returns a negative error code on error. When it does so, the value_str pointer will remain uninitialized and cause a crash later on when it is freed by OPENSSL_free(). Even if it wouldn't crash there, it still fails to signal the error and an empty string may be propagated to the callers. The check also mirrors the other one in the same file.
Note: this was found by a static-dynamic analyser I'm developing.
Supersedes nodejs/ncrypto#41