doc: document per-architecture fast FFI argument limits - #65207
Merged
nodejs-github-bot merged 1 commit intoAug 18, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Copy link
Copy Markdown
There was a problem hiding this comment.
Pull request overview
Updates the Fast FFI documentation to clarify when optimized Fast FFI falls back to the generic path by documenting per-architecture trampoline/register constraints.
Changes:
- Replaces the previous narrative description of Fast FFI argument limits with an architecture matrix.
- Adds explicit notes/definitions around buffer-shaped arguments and architectures without a fast-call trampoline (e.g., PPC64BE).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Sorry, something went wrong.
Comment thread
doc/api/ffi.md
Outdated
leah-1ee
force-pushed
the
doc-ffi-platform-argument-limits
branch
from
c337b36 to
3b33d30
Compare
August 11, 2026 05:18
The prior text covered only two of the seven supported architectures and conflated x86-64 SysV with the stricter Win64 emitter. Signed-off-by: leah-1ee <selee3196@gmail.com>
leah-1ee
force-pushed
the
doc-ffi-platform-argument-limits
branch
from
3b33d30 to
bfab024
Compare
August 11, 2026 05:22
ShogunPanda
approved these changes
Aug 17, 2026
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
The prior text covered only two of the seven supported architectures and conflated x86-64 SysV with the stricter Win64 emitter. Signed-off-by: leah-1ee <selee3196@gmail.com> PR-URL: #65207 Reviewed-By: Paolo Insogna <paolo@cowtech.it>
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
The prior text covered only two of the seven supported architectures and conflated x86-64 SysV with the stricter Win64 emitter. Signed-off-by: leah-1ee <selee3196@gmail.com> PR-URL: #65207 Reviewed-By: Paolo Insogna <paolo@cowtech.it>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Fast FFI argument-limit paragraph only documented AArch64 and
x86-64, conflating x86-64 SysV with the stricter Win64 x64 emitter
and leaving five architectures undocumented.
Replaces it with a table covering all seven fast-call architectures,
verified against src/ffi/types.cc and the trampoline generators in
src/ffi/platforms/*.cc.
Follow-up to #63960.