FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

typings: add watchdog internal binding types by leah-1ee · Pull Request #65228 · nodejs/node · GitHub

/ node Public

typings: add watchdog internal binding types - #65228

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
leah-1ee:typings-watchdog
Aug 17, 2026
Merged

typings: add watchdog internal binding types#65228
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
leah-1ee:typings-watchdog

Conversation

Copy link
Copy Markdown
Contributor

Add typings for the watchdog internal binding.

Changes:

  • Added typings/internalBinding/watchdog.d.ts
  • Added watchdog to InternalBindingMap
  • Typed TraceSigintWatchdog.start() and stop()

Add a WatchdogBinding declaration for internalBinding('watchdog')
and wire it into InternalBindingMap.

Signed-off-by: leah-1ee <selee3196@gmail.com>
Copilot AI lite review requested due to automatic review settings August 11, 2026 23:39

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Copilot wasn't able to review any files in this pull request.


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

daeyeon added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 15, 2026
daeyeon added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 17, 2026
nodejs-github-bot merged commit 11176fd into nodejs:main Aug 17, 2026
27 checks passed

Copy link
Copy Markdown
Collaborator

Landed in 11176fd

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 17, 2026
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
Add a WatchdogBinding declaration for internalBinding('watchdog')
and wire it into InternalBindingMap.

Signed-off-by: leah-1ee <selee3196@gmail.com>
PR-URL: #65228
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
Add a WatchdogBinding declaration for internalBinding('watchdog')
and wire it into InternalBindingMap.

Signed-off-by: leah-1ee <selee3196@gmail.com>
PR-URL: #65228
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. typings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL