FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: use for-of instead of forEach by devfep · Pull Request #65268 · nodejs/node · GitHub

/ node Public

test: use for-of instead of forEach - #65268

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
devfep:my-first-contribution
Aug 15, 2026
ConversationCommits (1)ChecksFiles changed
Merged

test: use for-of instead of forEach#65268
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
devfep:my-first-contribution

Conversation

devfep commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Signed-off-by: Felix P. devfep@gmail.com

test: use for-of instead of forEach
c762869 
Signed-off-by: Felix P. <devfep@gmail.com>
nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Aug 13, 2026
avivkeller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Aug 13, 2026
jasnell added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 13, 2026
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 13, 2026

This comment was marked as outdated.

Sign in to view

codecov Bot commented Aug 13, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.32%. Comparing base (1662b69) to head (c762869).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #65268   +/-   ##
=======================================
  Coverage   90.31%   90.32%           
=======================================
  Files         751      751           
  Lines      249776   249776           
  Branches    47173    47180    +7     
=======================================
+ Hits       225587   225608   +21     
+ Misses      15585    15577    -8     
+ Partials     8604     8591   -13

see 34 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nodejs-github-bot commented Aug 14, 2026 •
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75823/ 💛

jasnell added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 14, 2026

jasnell commented Aug 14, 2026

Copy link
Copy Markdown
Member

Thank you for the contribution and for participating in the code-and-learn! This has passed CI and is generally ready to land. Since there are two sign-offs, it will land after 48 hours have passed.

jasnell added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 14, 2026
Ethan-Arrowood approved these changes Aug 14, 2026
View reviewed changes

Ethan-Arrowood left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Great work!

nodejs-github-bot merged commit c2b2e3f into nodejs:main Aug 15, 2026
99 of 100 checks passed

nodejs-github-bot commented Aug 15, 2026

Copy link
Copy Markdown
Collaborator

Landed in c2b2e3f

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 15, 2026
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
test: use for-of instead of forEach
d421853 
Signed-off-by: Felix P. <devfep@gmail.com>
PR-URL: #65268
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
test: use for-of instead of forEach
7af0a96 
Signed-off-by: Felix P. <devfep@gmail.com>
PR-URL: #65268
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
github-actions Bot mentioned this pull request Aug 25, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
Ethan-Arrowood Ethan-Arrowood approved these changes
avivkeller avivkeller approved these changes
+1 more reviewer
bjohansebas bjohansebas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL