test: convert forEach to for in test-constant.js file - #65271
Closed
Nixxy25 wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
mertcanaltin
approved these changes
Aug 13, 2026
jasnell
approved these changes
Aug 14, 2026
This comment was marked as outdated.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Signed-off-by: NIxxy25 <tellaoyinkansola25@gmail.com>
Nixxy25
force-pushed
the
my-first-contribution
branch
from
04032f9 to
e0ace21
Compare
August 14, 2026 03:45
avivkeller
approved these changes
Aug 14, 2026
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #65271 +/- ##
==========================================
- Coverage 92.07% 90.32% -1.76%
==========================================
Files 399 751 +352
Lines 177007 250000 +72993
Branches 27381 47224 +19843
==========================================
+ Hits 162978 225810 +62832
- Misses 13716 15573 +1857
- Partials 313 8617 +8304 see 489 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/65271 ✔ Done loading data for nodejs/node/pull/65271 ----------------------------------- PR info ------------------------------------ Title test: convert forEach to for in test-constant.js file (#65271) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch Nixxy25:my-first-contribution -> nodejs:main Labels test, code-and-learn, author ready, needs-ci, commit-queue Commits 1 - feat: convert forEach to for in test-constant.js file Committers 1 - NIxxy25 <tellaoyinkansola25@gmail.com> PR-URL: https://github.com/nodejs/node/pull/65271 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Aviv Keller <me@aviv.sh> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/65271 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Aviv Keller <me@aviv.sh> -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 13 Aug 2026 20:05:32 GMT ✔ Approvals: 2 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/65271#pullrequestreview-4932942643 ✔ - Aviv Keller (@avivkeller): https://github.com/nodejs/node/pull/65271#pullrequestreview-4934054787 ✘ 2 GitHub CI job(s) failed: ✘ - lint-commit-message: FAILURE (https://github.com/nodejs/node/actions/runs/31767740201/job/95027864465) ✘ - x86_64-darwin: with shared libraries / build: FAILURE (https://github.com/nodejs/node/actions/runs/31767740332/job/95028005259) ℹ Last Full PR CI on 2026-08-14T02:32:58Z: https://ci.nodejs.org/job/node-test-pull-request/75827/ ⚠ Commits were pushed after the last Full PR CI run: ⚠ - feat: convert forEach to for in test-constant.js file - Querying data for job/node-test-pull-request/75827/ ✔ Build data downloaded - Querying failures of job/node-test-commit/90548/ ✔ Data downloaded ✘ 1 failure(s) on the last Jenkins CI run -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/31905918893 |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Note to whomever lands this: the commit message prefix will need to be manually fixed up to fix the linting. |
Sorry, something went wrong.
avivkeller
pushed a commit
that referenced
this pull request
Aug 15, 2026
Signed-off-by: NIxxy25 <tellaoyinkansola25@gmail.com> PR-URL: #65271 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Aviv Keller <me@aviv.sh>
Copy link
Copy Markdown
Member
|
I've landed it with an amended commit message (the only failure was linting the commit message prior to my amendment, skipped) |
Sorry, something went wrong.
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
Signed-off-by: NIxxy25 <tellaoyinkansola25@gmail.com> PR-URL: #65271 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
Signed-off-by: NIxxy25 <tellaoyinkansola25@gmail.com> PR-URL: #65271 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Aviv Keller <me@aviv.sh>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for...of is preferred over Array.prototype.forEach in the test suite:
clearer stack traces on failure, works with await, and avoids
allocating a callback per iteration.
RenderATL NodeJS Workshop