build: update binary-upload to use correct tarball name by sxa · Pull Request #65282 · nodejs/node · GitHub

The binary-upload target in the top level Makefile uses $(TARNAME)-$(OSTYPE)-$(ARCH).tar as the name to upload whereas it is created by the $(BINARYTAR) target as $(BINARYNAME).tar. Since BINARYNAME includes the optional VARIATION (set to musl) to distinguish it from linux-x64 this is missing during the binary-upload target, for example during a release build for Alpine/musl causing the error described in nodejs/build#4423 (comment)

This changes the binary-upload target to use the same variable for the tarball that is used when the file is created so there is consistency.

the binary-upload target uses $(TARNAME)-$(OSTYPE)-$(ARCH).tar.xz as the name to upload whereas it is created by the $(BINARYTAR) target as $(BINARYNAME). Since BINARYNAME includes the optional VARIATION when present this gets missed out int he binary-upload target, for example during a release build for Alpine/musl. This commit changes the binary-upload target to use the same variable for the tarball that is used when the file is created. Signed-off-by: Stewart X Addison <sxa@ibm.com>

Confirmed that it works with the test build at https://ci-release.nodejs.org/job/iojs+release/nodes=alpine-x64-release/12016/console

Noting that there may be further issues if the promotion step has any problems with the filenames including the extra VARIATION section.

CI: https://ci.nodejs.org/job/node-test-pull-request/75837/

Ping @nodejs/releasers for review in case there's anything I might have missed with this change or if there are other regexs etc. which may need to be changed elsewhere to handle this.

Noting that this is likely still a reasonable change even if other things are required as it does not seem to have a negative impact on any existing releases from what I can see as the filenames are as they were before - BINARYNAME is defined at

node/Makefile

Line 1108 in 9e23066

ifdef VARIATION

and the iojs+release job does not use VARIATION anywhere other than the new code added for Alpine.

CI: https://ci.nodejs.org/job/node-test-pull-request/75838/

CI: https://ci.nodejs.org/job/node-test-pull-request/75839/

(Not a blocking comment).

Noting here that $(BINARYNAME) is defined as

node/Makefile

Lines 1108 to 1112 in 9e23066

    
           ifdef VARIATION 
        
           BINARYNAME=$(TARNAME)-$(PLATFORM)-$(ARCH)-$(VARIATION) 
        
           else 
        
           BINARYNAME=$(TARNAME)-$(PLATFORM)-$(ARCH) 
        
           endif

whereas what is being replaced is

$(TARNAME)-$(OSTYPE)-$(ARCH)

$(OSTYPE) is defined as

node/Makefile

Lines 13 to 16 in 9e23066

    
           OSTYPE := $(shell uname -s | tr '[:upper:]' '[:lower:]') 
        
           ifeq ($(findstring os/390,$OSTYPE),os/390) 
        
           OSTYPE ?= os390 
        
           endif

$(PLATFORM) is defined as

node/Makefile

Lines 1001 to 1004 in 9e23066

    
           PLATFORM=$(shell uname | tr '[:upper:]' '[:lower:]') 
        
           ifeq ($(findstring os/390,$PLATFORM),os/390) 
        
           PLATFORM ?= os390 
        
           endif

i.e. they happen to have the same definition (as uname without parameters behaves as uname -s) which is how this has been working up until now 😅.

Using $(BINARYNAME) for consistency with what was created is much safer than the above, so +1.

As per the comments at nodejs/build#4423 (comment) we will need to get this backported to the release lines ASAP if we want to make this live. Once this is approved and merged in main I would recommend that we bypass the usual two week period for backporting, especially given that this is not a functional change to the runtime.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.31%. Comparing base (91a99c5) to head (f570c90).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #65282      +/-   ##
==========================================
- Coverage   90.32%   90.31%   -0.02%     
==========================================
  Files         751      751              
  Lines      250000   250000              
  Branches    47231    47230       -1     
==========================================
- Hits       225816   225788      -28     
- Misses      15566    15620      +54     
+ Partials     8618     8592      -26

see 35 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

As per the comments at nodejs/build#4423 (comment) we will need to get this backported to the release lines ASAP if we want to make this live. Once this is approved and merged in main I would recommend that we bypass the usual two week period for backporting, especially given that this is not a functional change to the runtime.

@nodejs/releasers thoughts? ☝️

Landed in ad7a5b8

the binary-upload target uses $(TARNAME)-$(OSTYPE)-$(ARCH).tar.xz as the name to upload whereas it is created by the $(BINARYTAR) target as $(BINARYNAME). Since BINARYNAME includes the optional VARIATION when present this gets missed out int he binary-upload target, for example during a release build for Alpine/musl. This commit changes the binary-upload target to use the same variable for the tarball that is used when the file is created. Signed-off-by: Stewart X Addison <sxa@ibm.com> PR-URL: #65282 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>

No objectins after a day from the release team to the above comment or in slack so I've backported and verified with Alpine (alpine-x64-release label) enabled in iojs+release as follows:

Branch	Commit	iojs+release test job
v26.x-staging	9dafc78cdf	12028
v24.x-staging	e2e5c4fe88	12027
v22.x-staging	e21045ec51	12025

the binary-upload target uses $(TARNAME)-$(OSTYPE)-$(ARCH).tar.xz as the name to upload whereas it is created by the $(BINARYTAR) target as $(BINARYNAME). Since BINARYNAME includes the optional VARIATION when present this gets missed out int he binary-upload target, for example during a release build for Alpine/musl. This commit changes the binary-upload target to use the same variable for the tarball that is used when the file is created. Signed-off-by: Stewart X Addison <sxa@ibm.com> PR-URL: #65282 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>

nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Aug 14, 2026

richardlau approved these changes Aug 14, 2026

View reviewed changes

richardlau mentioned this pull request Aug 14, 2026

Provide Alpine agent in release CI nodejs/build#4423

Open

8 tasks

sxa mentioned this pull request Aug 14, 2026

ansible: add alpine/musl builds to expected assets nodejs/build#4428

Merged

sxa marked this pull request as ready for review August 14, 2026 13:33

lpinca approved these changes Aug 14, 2026

View reviewed changes

gurgunday approved these changes Aug 14, 2026

View reviewed changes

richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 14, 2026

nodejs-github-bot merged commit ad7a5b8 into nodejs:main Aug 16, 2026
97 checks passed

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 16, 2026

This was referenced Aug 20, 2026

2026-09-01, Version 22.23.3 'Jod' (LTS) #65443

Closed

2026-09-01, Version 22.23.3 'Jod' (LTS) #65448

Open

2026-08-26, Version 24.20.0 'Krypton' (LTS) #65461

Open

-              	chmod 664 $(TARNAME)-$(OSTYPE)-$(ARCH).tar.gz
-              	scp -p $(TARNAME)-$(OSTYPE)-$(ARCH).tar.gz $(STAGINGSERVER):nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(TARNAME)-$(OSTYPE)-$(ARCH).tar.gz
-              	ssh $(STAGINGSERVER) "rclone copyto nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(TARNAME)-$(OSTYPE)-$(ARCH).tar.gz $(CLOUDFLARE_BUCKET)/nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(TARNAME)-$(OSTYPE)-$(ARCH).tar.gz"
-              	ssh $(STAGINGSERVER) "touch nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(TARNAME)-$(OSTYPE)-$(ARCH).tar.gz.done"
+              	chmod 664 $(BINARYNAME).tar.gz
+              	scp -p $(BINARYNAME).tar.gz $(STAGINGSERVER):nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(BINARYNAME).tar.gz
+              	ssh $(STAGINGSERVER) "rclone copyto nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(BINARYNAME).tar.gz $(CLOUDFLARE_BUCKET)/nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(BINARYNAME).tar.gz"
+              	ssh $(STAGINGSERVER) "touch nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(BINARYNAME).tar.gz.done"

	ifdef VARIATION
	BINARYNAME=$(TARNAME)-$(PLATFORM)-$(ARCH)-$(VARIATION)
	else
	BINARYNAME=$(TARNAME)-$(PLATFORM)-$(ARCH)
	endif

	OSTYPE := $(shell uname -s \| tr '[:upper:]' '[:lower:]')
	ifeq ($(findstring os/390,$OSTYPE),os/390)
	OSTYPE ?= os390
	endif

	PLATFORM=$(shell uname \| tr '[:upper:]' '[:lower:]')
	ifeq ($(findstring os/390,$PLATFORM),os/390)
	PLATFORM ?= os390
	endif

build: update binary-upload to use correct tarball name by sxa · Pull Request #65282 · nodejs/node · GitHub

Uh oh!

Uh oh!

build: update binary-upload to use correct tarball name - #65282

build: update binary-upload to use correct tarball name#65282nodejs-github-bot merged 1 commit intonodejs:mainnodejs/node:mainfrom sxa:binary-variationsxa/node:binary-variationCopy head branch name to clipboard

Conversation

sxa commented Aug 14, 2026

Uh oh!

sxa commented Aug 14, 2026

Uh oh!

nodejs-github-bot commented Aug 14, 2026

Uh oh!

sxa commented Aug 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Aug 14, 2026

Uh oh!

nodejs-github-bot commented Aug 14, 2026

Uh oh!

richardlau Aug 14, 2026

Choose a reason for hiding this comment

Uh oh!

sxa commented Aug 14, 2026

Uh oh!

codecov Bot commented Aug 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

richardlau commented Aug 14, 2026

Uh oh!

Uh oh!

nodejs-github-bot commented Aug 16, 2026

Uh oh!

sxa commented Aug 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

build: update binary-upload to use correct tarball name#65282
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
sxa:binary-variation

sxa commented Aug 14, 2026 •
edited
Loading

codecov Bot commented Aug 14, 2026 •
edited
Loading

sxa commented Aug 18, 2026 •
edited
Loading