FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: add missing `added:` tags to `fs.lchmod` by lazerg · Pull Request #65283 · nodejs/node · GitHub

/ node Public

doc: add missing added: tags to fs.lchmod - #65283

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
lazerg:fix/issue-65280-lchmod-added-history
Aug 16, 2026
ConversationCommits (2)ChecksFiles changed
Merged

doc: add missing added: tags to fs.lchmod#65283
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
lazerg:fix/issue-65280-lchmod-added-history

Conversation

lazerg commented Aug 14, 2026 •
edited by aduh95
Loading

Copy link
Copy Markdown
Contributor

The history dropdown for fs.lchmod, fs.lchmodSync, and fsPromises.lchmod only shows when each was deprecated, not when it was added. I traced the original addition through the v0.5.0 ChangeLog (issue nodejs/node-v0.x-archive#853) and the initial fs/promises implementation (#18297), and filled in the missing added: version for each.

Fixes: #65280
Refs: nodejs/node-v0.x-archive#853
Refs: 3935adc
Refs: #18297

doc: add missing added: tags to fs.lchmod
f4ba2df 
Signed-off-by: Lazizbek Ergashev <lazerg2@gmail.com>
nodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Aug 14, 2026
aduh95 reviewed Aug 14, 2026
View reviewed changes
Comment thread doc/api/fs.md Outdated
aduh95 reviewed Aug 14, 2026
View reviewed changes
Comment thread doc/api/fs.md Outdated
doc: fix inaccurate deprecated version for fs.lchmod
d3d7131 
Signed-off-by: Lazizbek Ergashev <lazerg2@gmail.com>
aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Aug 14, 2026
aduh95 mentioned this pull request Aug 14, 2026
Closed

ashrees commented Aug 14, 2026

Copy link
Copy Markdown

Nice work — I independently traced the same source (v0.5.0 via nodejs/node-v0.x-archive#853) before noticing this PR. One possible follow-up: the existing deprecated: v0.4.7 predates the v0.5.0 introduction, which looks inconsistent — happy to open a separate issue for the deprecation date if collaborators agree.

lazerg commented Aug 14, 2026

Copy link
Copy Markdown
Contributor Author

Good catch, and yeah, that's the same rabbit hole. Turns out that one was already flagged in review, v0.4.7 predates fs.lchmod existing entirely (confirmed against CHANGELOG_ARCHIVE.md, fs.lchmod only shows up in v0.5.0 via #853). Already fixed it in this PR, deprecated now reads v0.5.0 too. No need for a separate issue.

Hardanish-Singh reviewed Aug 15, 2026
View reviewed changes

Hardanish-Singh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

nodejs-github-bot merged commit 46cac5a into nodejs:main Aug 16, 2026
26 checks passed

nodejs-github-bot commented Aug 16, 2026

Copy link
Copy Markdown
Collaborator

Landed in 46cac5a

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 16, 2026
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
doc: add missing added: tags to fs.lchmod
81f2913 
Signed-off-by: Lazizbek Ergashev <lazerg2@gmail.com>
PR-URL: #65283
Fixes: #65280
Refs: nodejs/node-v0.x-archive#853
Refs: 3935adc
Refs: #18297
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
doc: add missing added: tags to fs.lchmod
3b6a918 
Signed-off-by: Lazizbek Ergashev <lazerg2@gmail.com>
PR-URL: #65283
Fixes: #65280
Refs: nodejs/node-v0.x-archive#853
Refs: 3935adc
Refs: #18297
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
github-actions Bot mentioned this pull request Aug 25, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
aduh95 aduh95 approved these changes
+1 more reviewer
Hardanish-Singh Hardanish-Singh left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incomplete history of the method fs.lchmod

6 participants

Back | FazBrowse Home | New Git URL