test: wait for FFI background optimization - #65300
Merged
nodejs-github-bot merged 1 commit intoAug 15, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
The pointer range test creates multiple closures from the same function literals and explicitly requests synchronous optimization. V8 can also schedule concurrent recompilation for those closures. Wait for background optimization before closing the dynamic library so compiler jobs cannot outlive the fast FFI metadata they reference. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: codex:gpt-5.6-sol
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Fast-track has been requested by @trivikr. Please 👍 to approve. |
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #65300 +/- ##
==========================================
+ Coverage 90.30% 90.33% +0.02%
==========================================
Files 751 751
Lines 250235 250235
Branches 47305 47303 -2
==========================================
+ Hits 225987 226044 +57
+ Misses 15619 15566 -53
+ Partials 8629 8625 -4 see 38 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
avivkeller
approved these changes
Aug 15, 2026
Copy link
Copy Markdown
Member
Author
|
Removed request-ci as it was run manually in #65300 (comment) |
Sorry, something went wrong.
gurgunday
approved these changes
Aug 15, 2026
gurgunday
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
For some reason, the stress test is not detecting the test file for PR. In main + /home/iojs/venv/bin/python3.12 tools/test.py -p tap --logfile test1.tap --mode=release ffi/test-ffi-fast-integer-validation
TAP version 13
1..1
ok 1 ffi/test-ffi-fast-integer-validation
---
duration_ms: 413.13500
...
All tests passed.https://ci.nodejs.org/job/node-stress-single-test/828 For PR + /home/iojs/venv/bin/python3.12 tools/test.py -p tap --logfile test1.tap --mode=release ffi/test-ffi-fast-integer-validation
No tests to run.
+ NOK=1
+ echo '1 OK: 0 NOT OK: 1 TOTAL: 1000'
1 OK: 0 NOT OK: 1 TOTAL: 1000
+ tap2junit -i test1.tap -o test1.xml
Traceback (most recent call last):
File "/home/iojs/venv/bin/tap2junit", line 8, in <module>
sys.exit(main())
^^^^^^
File "/home/iojs/venv/lib/python3.12/site-packages/tap2junit/__main__.py", line 94, in main
convert(
File "/home/iojs/venv/lib/python3.12/site-packages/tap2junit/__main__.py", line 68, in convert
result = parse(name or input_file, data, package)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/iojs/venv/lib/python3.12/site-packages/tap2junit/__main__.py", line 58, in parse
tap_parser.parse(data)
File "/home/iojs/venv/lib/python3.12/site-packages/tap2junit/tap13.py", line 237, in parse
self._parse(io.StringIO(source))
File "/home/iojs/venv/lib/python3.12/site-packages/tap2junit/tap13.py", line 107, in _parse
match = RE_VERSION.match(non_empty_lines[0])
~~~~~~~~~~~~~~~^^^
IndexError: list index out of range
+ truehttps://ci.nodejs.org/job/node-stress-single-test/829 I've confirmed by running the test locally though
|
Sorry, something went wrong.
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
The pointer range test creates multiple closures from the same function literals and explicitly requests synchronous optimization. V8 can also schedule concurrent recompilation for those closures. Wait for background optimization before closing the dynamic library so compiler jobs cannot outlive the fast FFI metadata they reference. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: codex:gpt-5.6-sol PR-URL: #65300 Refs: https://github.com/nodejs/reliability/issues?q=sort%3Aupdated-desc%20%22test-ffi-fast-integer-validation%22 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
The pointer range test creates multiple closures from the same function literals and explicitly requests synchronous optimization. V8 can also schedule concurrent recompilation for those closures. Wait for background optimization before closing the dynamic library so compiler jobs cannot outlive the fast FFI metadata they reference. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: codex:gpt-5.6-sol PR-URL: #65300 Refs: https://github.com/nodejs/reliability/issues?q=sort%3Aupdated-desc%20%22test-ffi-fast-integer-validation%22 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: https://github.com/nodejs/reliability/issues?q=sort%3Aupdated-desc%20%22test-ffi-fast-integer-validation%22
The pointer range test creates multiple closures from the same function literals and explicitly requests synchronous optimization. V8 can also schedule concurrent recompilation for those closures.
Wait for background optimization before closing the dynamic library so compiler jobs cannot outlive the fast FFI metadata they reference.
Assisted-by: codex:gpt-5.6-sol