diagnostics_channel: validate before channel activation - #65313
Merged
nodejs-github-bot merged 1 commit intoAug 20, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Validate the first subscription before calling markActive(). This prevents invalid callbacks from leaving channels active and notifying native consumers without an installed subscriber. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: codex:gpt-5.6-sol
jasnell
approved these changes
Aug 15, 2026
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #65313 +/- ##
==========================================
- Coverage 90.31% 90.13% -0.19%
==========================================
Files 751 752 +1
Lines 250474 251569 +1095
Branches 47335 47269 -66
==========================================
+ Hits 226218 226750 +532
- Misses 15601 16169 +568
+ Partials 8655 8650 -5
... and 68 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Flarna
approved these changes
Aug 19, 2026
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
Validate the first subscription before calling markActive(). This prevents invalid callbacks from leaving channels active and notifying native consumers without an installed subscriber. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: codex:gpt-5.6-sol PR-URL: #65313 Fixes: #65312 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
Validate the first subscription before calling markActive(). This prevents invalid callbacks from leaving channels active and notifying native consumers without an installed subscriber. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: codex:gpt-5.6-sol PR-URL: #65313 Fixes: #65312 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #65312
Validate the first subscription before calling markActive(). This prevents invalid callbacks from leaving channels active and notifying native consumers without an installed subscriber.
Assisted-by: codex:gpt-5.6-sol