FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

quic: mark drain promise handled by jasnell · Pull Request #65319 · nodejs/node · GitHub

/ node Public

quic: mark drain promise handled - #65319

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
jasnell:jasnell/mark-drain-promise-handled
Aug 23, 2026
ConversationCommits (1)ChecksFiles changed
Merged

quic: mark drain promise handled#65319
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
jasnell:jasnell/mark-drain-promise-handled

Conversation

jasnell commented Aug 16, 2026

Copy link
Copy Markdown
Member

Fixes: #64290

@nodejs/quic @martenrichter

quic: mark drain promise handled
39fa1e0 
Fixes: nodejs#64290
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus

nodejs-github-bot commented Aug 16, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/quic

nodejs-github-bot added needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3. labels Aug 16, 2026

nodejs-github-bot commented Aug 16, 2026 •
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75874/ 💚

codecov Bot commented Aug 16, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.11%. Comparing base (86c871e) to head (39fa1e0).
⚠️ Report is 112 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #65319      +/-   ##
==========================================
- Coverage   90.12%   90.11%   -0.01%     
==========================================
  Files         752      752              
  Lines      251569   251571       +2     
  Branches    47267    47267              
==========================================
- Hits       226738   226715      -23     
- Misses      16184    16201      +17     
- Partials     8647     8655       +8
Files with missing lines Coverage Δ
lib/internal/quic/quic.js 100.00% <100.00%> (ø)

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

martenrichter commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

lgtm Thanks!

jasnell requested review from Qard and pimterry August 16, 2026 13:50
jasnell added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 17, 2026
trivikr added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 22, 2026
nodejs-github-bot merged commit c1d3132 into nodejs:main Aug 23, 2026
92 of 93 checks passed

nodejs-github-bot commented Aug 23, 2026

Copy link
Copy Markdown
Collaborator

Landed in c1d3132

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 23, 2026
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
quic: mark drain promise handled
ad2ac3f 
Fixes: #64290
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
PR-URL: #65319
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
quic: mark drain promise handled
9139389 
Fixes: #64290
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
PR-URL: #65319
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
github-actions Bot mentioned this pull request Aug 25, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Qard Qard approved these changes
pimterry Awaiting requested review from pimterry

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

quic: QuicStream writer creates unhandled error

5 participants

Back | FazBrowse Home | New Git URL