FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test_runner: fix junit report on empty diagnostic by lazerg · Pull Request #65357 · nodejs/node · GitHub

/ node Public

test_runner: fix junit report on empty diagnostic - #65357

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
lazerg:fix/issue-65355-junit-empty-diagnostic
Aug 19, 2026
ConversationCommits (1)ChecksFiles changed
Merged

test_runner: fix junit report on empty diagnostic#65357
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
lazerg:fix/issue-65355-junit-empty-diagnostic

Conversation

lazerg commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

context.diagnostic('') makes the junit reporter throw. treeToXML guards the comment branch with if (comment), so an empty message falls through to the element branch and ObjectEntries(attrs) gets called on undefined. The generator dies, the destination stream is destroyed, and the report is left without its closing </testsuites>.

Comment nodes are already identified by comment == null elsewhere in the reporter, so the guard now checks the same way and an empty diagnostic renders as an empty XML comment.

Fixes: #65355

nodejs-github-bot commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Aug 17, 2026
atlowChemi approved these changes Aug 17, 2026
View reviewed changes

atlowChemi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Perhaps this should be tested with a .snapshot (see example

node/test/test-runner/test-output-abort-hooks.mjs

Line 1 in 3781ebc

// Test that the output of test-runner/output/abort_hooks.js matches test-runner/output/abort_hooks.snapshot
)

test_runner: fix junit report on empty diagnostic
0a00f28 
Signed-off-by: Lazizbek Ergashev <lazerg2@gmail.com>
lazerg force-pushed the fix/issue-65355-junit-empty-diagnostic branch from f70a693 to 0a00f28 Compare August 17, 2026 19:43

lazerg commented Aug 17, 2026

Copy link
Copy Markdown
Contributor Author

Switched to a snapshot in 0a00f28. test/test-runner/test-output-junit-empty-diagnostic.mjs now compares against junit_empty_diagnostic.snapshot, which pins both the empty <!-- --> comment and the closing </testsuites>. That replaced the assertion-based case I had in test-runner-reporters.js, so I squashed the branch back into one commit.

benjamingr added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 17, 2026
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 17, 2026

nodejs-github-bot commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75948/

atlowChemi added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 17, 2026

codecov Bot commented Aug 17, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.11%. Comparing base (6456418) to head (0a00f28).
⚠️ Report is 24 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #65357      +/-   ##
==========================================
- Coverage   90.12%   90.11%   -0.01%     
==========================================
  Files         752      752              
  Lines      251865   251872       +7     
  Branches    47353    47362       +9     
==========================================
- Hits       226991   226984       -7     
+ Misses      16223    16213      -10     
- Partials     8651     8675      +24
Files with missing lines Coverage Δ
lib/internal/test_runner/reporter/junit.js 94.76% <100.00%> (ø)

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nodejs-github-bot commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75989/

MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 19, 2026
nodejs-github-bot merged commit 03fb384 into nodejs:main Aug 19, 2026
74 checks passed

nodejs-github-bot commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Landed in 03fb384

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 19, 2026
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
test_runner: fix junit report on empty diagnostic
af8df85 
Signed-off-by: Lazizbek Ergashev <lazerg2@gmail.com>
PR-URL: #65357
Fixes: #65355
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
test_runner: fix junit report on empty diagnostic
9572a0b 
Signed-off-by: Lazizbek Ergashev <lazerg2@gmail.com>
PR-URL: #65357
Fixes: #65355
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
github-actions Bot mentioned this pull request Aug 25, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

benjamingr benjamingr approved these changes
MoLow MoLow approved these changes
atlowChemi atlowChemi approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test_runner: JUnit report is truncated when a failed test triggers empty context.diagnostic()

5 participants

Back | FazBrowse Home | New Git URL