FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

permission: guard UDP handle adoption by RafaelGSS · Pull Request #65358 · nodejs/node · GitHub

/ node Public

permission: guard UDP handle adoption - #65358

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
RafaelGSS:fix-permission-udp-handle-receive
Aug 24, 2026
Merged

permission: guard UDP handle adoption#65358
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
RafaelGSS:fix-permission-udp-handle-receive

Conversation

Copy link
Copy Markdown
Member

Ensures IPC (parent -> child communication) passes by permission model checks.

RafaelGSS added the permission Issues and PRs related to the Permission Model label Aug 17, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/net
  • @nodejs/security-wg

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dgram Issues and PRs related to the dgram subsystem / UDP. needs-ci PRs that need a full CI run. labels Aug 17, 2026
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
RafaelGSS force-pushed the fix-permission-udp-handle-receive branch from 49658da to ec5672e Compare August 17, 2026 22:14

codecov Bot commented Aug 17, 2026
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.13%. Comparing base (45d6d31) to head (ec5672e).
⚠️ Report is 130 commits behind head on main.

Files with missing lines Patch % Lines
src/udp_wrap.cc 66.66% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #65358      +/-   ##
==========================================
- Coverage   90.13%   90.13%   -0.01%     
==========================================
  Files         752      752              
  Lines      251872   251892      +20     
  Branches    47359    47371      +12     
==========================================
+ Hits       227033   227045      +12     
- Misses      16167    16172       +5     
- Partials     8672     8675       +3     
Files with missing lines Coverage Δ
src/udp_wrap.h 100.00% <ø> (ø)
src/udp_wrap.cc 78.54% <66.66%> (-0.25%) ⬇️

... and 26 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

RafaelGSS added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 19, 2026
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

RafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 24, 2026
nodejs-github-bot merged commit 18eaa73 into nodejs:main Aug 24, 2026
74 checks passed

Copy link
Copy Markdown
Collaborator

Landed in 18eaa73

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 24, 2026
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
PR-URL: #65358
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
PR-URL: #65358
Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. dgram Issues and PRs related to the dgram subsystem / UDP. needs-ci PRs that need a full CI run. permission Issues and PRs related to the Permission Model

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL