url: speed up URLSearchParams - #65363
Merged
nodejs-github-bot merged 2 commits intoAug 22, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
This was referenced Aug 18, 2026
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #65363 +/- ##
==========================================
- Coverage 90.31% 90.11% -0.20%
==========================================
Files 751 752 +1
Lines 249956 251862 +1906
Branches 47204 47356 +152
==========================================
+ Hits 225745 226969 +1224
- Misses 15612 16235 +623
- Partials 8599 8658 +59
... and 90 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
jasnell
previously requested changes
Aug 18, 2026
jasnell
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
AI agents are not permitted to use Signed-off-by
Sorry, something went wrong.
cursor
Bot
force-pushed
the
cursor/url-searchparams-performance-603e
branch
from
1423a66 to
e18874e
Compare
August 18, 2026 11:39
Copy link
Copy Markdown
Member
Author
|
Removed the Signed-off-by trailer from the commit(s). An AI agent cannot attest the DCO. |
Sorry, something went wrong.
cursor
Bot
force-pushed
the
cursor/url-searchparams-performance-603e
branch
from
e18874e to
9863db8
Compare
August 18, 2026 12:49
Parse query strings with indexOf instead of a per-character state machine, skip ToString when values are already strings, cache toString() until the list mutates, and join serialized pairs. Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com> Assisted-by: Cursor
Leave lone '%' and non-hex percent sequences intact so serialization matches the previous parser, and use native indexOf/slice/push on the query-string hot path. Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com> Assisted-by: Cursor
cursor
Bot
force-pushed
the
cursor/url-searchparams-performance-603e
branch
3 times, most recently
from
18331fb to
eb812ac
Compare
August 18, 2026 18:43
Comment thread
lib/internal/url.js
| } | ||
| const out = []; | ||
| // Native indexOf/slice/push outperform primordials on this tight loop. | ||
| const encoded = qs.indexOf('+', i) !== -1 || qs.indexOf('%', i) !== -1; |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
nit:
Suggested change
| const encoded = qs.indexOf('+', i) !== -1 || qs.indexOf('%', i) !== -1; | |
| const hasPlus = qs.indexOf('+', i) !== -1; | |
| const hasPercent = qs.indexOf('%', i) !== -1; | |
| const encoded = hasPlus || hasPercent; |
Sorry, something went wrong.
Comment thread
test/parallel/test-whatwg-url-searchparams-fast-path.js
Comment on lines
+38
to
+40
| } | ||
|
|
||
| { |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
We can add edge case for fast path change
?, &&&, a=%2F%20b, a=%E2%82%AC, a=%c3%28
Suggested change
| } | |
| { | |
| } | |
| { | |
| const params = new URLSearchParams('?'); | |
| assert.deepStrictEqual([...params], []); | |
| assert.strictEqual(params.toString(), ''); | |
| } | |
| { | |
| const params = new URLSearchParams('&&&'); | |
| assert.deepStrictEqual([...params], []); | |
| assert.strictEqual(params.toString(), ''); | |
| } | |
| { | |
| const params = new URLSearchParams('a=%2F%20b'); | |
| assert.strictEqual(params.get('a'), '/ b'); | |
| assert.strictEqual(params.toString(), 'a=%2F+b'); | |
| } | |
| { | |
| const params = new URLSearchParams('a=%E2%82%AC'); | |
| assert.strictEqual(params.get('a'), '€'); | |
| assert.strictEqual(params.toString(), 'a=%E2%82%AC'); | |
| } | |
| { | |
| const params = new URLSearchParams('a=%c3%28'); | |
| assert.strictEqual(params.get('a'), '%c3%28'); | |
| assert.strictEqual(params.toString(), 'a=%25c3%2528'); | |
| } | |
| { |
Sorry, something went wrong.
mcollina
approved these changes
Aug 21, 2026
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
This comment was marked as outdated.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
gurgunday
approved these changes
Aug 21, 2026
gurgunday
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Lgtm
Sorry, something went wrong.
avivkeller
approved these changes
Aug 21, 2026
mohamedelhalosy2023-stack
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
ه
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/65363 ✔ Done loading data for nodejs/node/pull/65363 ----------------------------------- PR info ------------------------------------ Title url: speed up URLSearchParams (#65363) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch anonrig:cursor/url-searchparams-performance-603e -> nodejs:main Labels whatwg-url, needs-ci, commit-queue, commit-queue-squash Commits 2 - url: speed up URLSearchParams - url: only percent-decode complete %HH sequences Committers 1 - Yagiz Nizipli <yagiz@nizipli.com> PR-URL: https://github.com/nodejs/node/pull/65363 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Aviv Keller <me@aviv.sh> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/65363 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Aviv Keller <me@aviv.sh> -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 18 Aug 2026 01:38:00 GMT ✔ Approvals: 3 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/65363#pullrequestreview-4988761883 ✔ - Gürgün Dayıoğlu (@gurgunday): https://github.com/nodejs/node/pull/65363#pullrequestreview-4996082466 ✔ - Aviv Keller (@avivkeller): https://github.com/nodejs/node/pull/65363#pullrequestreview-4996124171 ✘ GitHub CI is still running ℹ Last Full PR CI on 2026-08-21T15:26:43Z: https://ci.nodejs.org/job/node-test-pull-request/76158/ - Querying data for job/node-test-pull-request/76158/ ✔ Build data downloaded ✘ Last Jenkins CI still running -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/32519106371 |
Sorry, something went wrong.
This comment was marked as spam.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
Parse query strings with indexOf instead of a per-character state machine, skip ToString when values are already strings, cache toString() until the list mutates, and join serialized pairs. Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com> Assisted-by: Cursor PR-URL: #65363 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
Parse query strings with indexOf instead of a per-character state machine, skip ToString when values are already strings, cache toString() until the list mutates, and join serialized pairs. Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com> Assisted-by: Cursor PR-URL: #65363 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Aviv Keller <me@aviv.sh>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This speeds up WHATWG URLSearchParams without changing observable behavior.
Independent of the new URL() parse PR (#65361).
What changed
Tests
Local benches
Same binary family, both run with --no-node-snapshot (new JS is not in the V8 snapshot). Rates in ops/s:
The large toString() jump is the serialization cache: the common “build params, stringify many times / read URL.href” path no longer re-encodes an unchanged list.
Ada already has a C url_search_params API. This keeps the implementation in JS to avoid a JS/C++ call on every get/append.
Assisted-by: Cursor