FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: add Headers coverage and benchmark by anonrig · Pull Request #65365 · nodejs/node · GitHub

/ node Public

test: add Headers coverage and benchmark - #65365

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:cursor/headers-class-performance-859a
Aug 22, 2026
ConversationCommits (1)ChecksFiles changed
Merged

test: add Headers coverage and benchmark#65365
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:cursor/headers-class-performance-859a

Conversation

anonrig commented Aug 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Adds Node-side coverage for the WHATWG Headers API and a fetch/headers benchmark.

These tests are not from WPT. They cover constructor init, get/set/append/delete, set-cookie / getSetCookie(), iteration (including mutation during iteration), validation, brand checks, and util.inspect.

The implementation change lives in undici:

Refs: nodejs/undici#5699

nodejs-github-bot commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/performance
  • @nodejs/security-wg

cursor Bot mentioned this pull request Aug 18, 2026
Draft
nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Aug 18, 2026
test: add Headers coverage and benchmark
0225f7b 
Add WHATWG Headers unit tests and a fetch/headers benchmark so Node
can track the API after the implementation change lands in undici.

Refs: nodejs/undici#5699
Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com>
cursor Bot force-pushed the cursor/headers-class-performance-859a branch from 3ea8120 to eb22154 Compare August 18, 2026 01:59
anonrig changed the title deps: improve Headers class performance test: add Headers coverage and benchmark Aug 18, 2026
cursor Bot force-pushed the cursor/headers-class-performance-859a branch from eb22154 to 2edacb0 Compare August 18, 2026 02:06
anonrig marked this pull request as ready for review August 18, 2026 02:06
jasnell previously requested changes Aug 18, 2026
View reviewed changes

jasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

AI agents are not permitted to use the Signed-off-by

codecov Bot commented Aug 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.14%. Comparing base (f83e7df) to head (2edacb0).
⚠️ Report is 48 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #65365      +/-   ##
==========================================
- Coverage   90.31%   90.14%   -0.18%     
==========================================
  Files         751      752       +1     
  Lines      249956   251884    +1928     
  Branches    47204    47379     +175     
==========================================
+ Hits       225745   227054    +1309     
- Misses      15612    16147     +535     
- Partials     8599     8683      +84

see 98 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mcollina approved these changes Aug 18, 2026
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Code LGTM. Commit metadata needs fixing.

cursor Bot force-pushed the cursor/headers-class-performance-859a branch from 2edacb0 to 0225f7b Compare August 18, 2026 12:49

anonrig commented Aug 18, 2026

Copy link
Copy Markdown
Member Author

Addressed the review feedback:

  • Removed the AI Signed-off-by. The commit is now authored and signed off by Yagiz Nizipli.
  • Fixed the quote-props lint failures in benchmark/fetch/headers.js and test/parallel/test-whatwg-headers.js.

anonrig added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 18, 2026
jasnell dismissed their stale review August 18, 2026 22:57

Resolved

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 18, 2026

nodejs-github-bot commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75976/

anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 19, 2026

nodejs-github-bot commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75994/

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 20, 2026

nodejs-github-bot commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/65365
✔  Done loading data for nodejs/node/pull/65365
----------------------------------- PR info ------------------------------------
Title      test: add Headers coverage and benchmark (#65365)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     anonrig:cursor/headers-class-performance-859a -> nodejs:main
Labels     author ready, needs-ci, dependencies, commit-queue
Commits    1
 - test: add Headers coverage and benchmark
Committers 1
 - Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: https://github.com/nodejs/node/pull/65365
Refs: https://github.com/nodejs/undici/pull/5699
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/65365
Refs: https://github.com/nodejs/undici/pull/5699
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 18 Aug 2026 01:56:23 GMT
   ✔  Approvals: 2
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/65365#pullrequestreview-4957135129
   ✔  - Gürgün Dayıoğlu (@gurgunday): https://github.com/nodejs/node/pull/65365#pullrequestreview-4964152707
   ✘  GitHub CI failed with status: FAILURE
   ℹ  Last Full PR CI on 2026-08-19T14:17:00Z: https://ci.nodejs.org/job/node-test-pull-request/75994/
- Querying data for job/node-test-pull-request/75994/
✔  Build data downloaded
- Querying failures of job/node-test-commit/90731/
✔  Data downloaded
   ✘  3 failure(s) on the last Jenkins CI run
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/32324366349

This comment was marked as outdated.

Sign in to view

nodejs-github-bot commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/76132/

nodejs-github-bot commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/76153/

nodejs-github-bot commented Aug 22, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/76225/

anonrig added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Aug 22, 2026
nodejs-github-bot merged commit cc57cb7 into nodejs:main Aug 22, 2026
83 checks passed

nodejs-github-bot commented Aug 22, 2026

Copy link
Copy Markdown
Collaborator

Landed in cc57cb7

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 22, 2026
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
test: add Headers coverage and benchmark
8494625 
Add WHATWG Headers unit tests and a fetch/headers benchmark so Node
can track the API after the implementation change lands in undici.

Refs: nodejs/undici#5699
Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: #65365
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
test: add Headers coverage and benchmark
acaf986 
Add WHATWG Headers unit tests and a fetch/headers benchmark so Node
can track the API after the implementation change lands in undici.

Refs: nodejs/undici#5699
Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: #65365
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
github-actions Bot mentioned this pull request Aug 25, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
gurgunday gurgunday approved these changes
jasnell jasnell left review comments
+1 more reviewer
mertcanaltin mertcanaltin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL