FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Revert "fs: fix close listener leak in FileHandle streams" by MikeMcC399 · Pull Request #65387 · nodejs/node · GitHub

/ node Public

Revert "fs: fix close listener leak in FileHandle streams" - #65387

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
MikeMcC399:revert-64227
Aug 19, 2026
ConversationCommits (1)ChecksFiles changed
Merged

Revert "fs: fix close listener leak in FileHandle streams"#65387
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
MikeMcC399:revert-64227

Conversation

MikeMcC399 commented Aug 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Refs: #64227
Refs: #64214

This reverts commit 8488e13.

@ronag wrote in #64227 (comment)

This is broken and should be reverted. Will unref the handle multiple times.

cc: @Y1D7NG @davidje13

Revert "fs: fix close listener leak in FileHandle streams"
5f3e792 
This reverts commit 8488e13.

It was advised that the fix in question is broken since
it will unref the handle multiple times.

Signed-off-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Aug 18, 2026
MikeMcC399 marked this pull request as ready for review August 18, 2026 16:00
ovflowd added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 18, 2026
ovflowd removed the needs-ci PRs that need a full CI run. label Aug 18, 2026

github-actions Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @ovflowd. Please 👍 to approve.

ovflowd commented Aug 18, 2026

Copy link
Copy Markdown
Member

Removed need of CI, since we're reverting to previous code, this is known to be stable. Added fast-track.

ronag commented Aug 18, 2026

Copy link
Copy Markdown
Member

Proper fix is to use eos/finished instead of 'close' listener

MikeMcC399 mentioned this pull request Aug 18, 2026
Open
panva added needs-ci PRs that need a full CI run. request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. labels Aug 18, 2026
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 18, 2026

nodejs-github-bot commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75970/

panva commented Aug 18, 2026

Copy link
Copy Markdown
Member

Removed need of CI, since we're reverting to previous code, this is known to be stable. Added fast-track.

The needs-ci label doesn't drive the need for CI. Removing it does absolutely nothing. CI is needed even for a revert, especially since other commits landed since that mean the codebase is not returning to a known state.

codecov Bot commented Aug 18, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.12%. Comparing base (cf30b2e) to head (5f3e792).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #65387      +/-   ##
==========================================
+ Coverage   90.11%   90.12%   +0.01%     
==========================================
  Files         752      752              
  Lines      251861   251849      -12     
  Branches    47365    47363       -2     
==========================================
+ Hits       226955   226984      +29     
+ Misses      16238    16192      -46     
- Partials     8668     8673       +5
Files with missing lines Coverage Δ
lib/internal/fs/streams.js 93.10% <100.00%> (-0.14%) ⬇️

... and 35 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nodejs-github-bot commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75979/

MikeMcC399 mentioned this pull request Aug 19, 2026
Merged
MikeMcC399 added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 19, 2026
nodejs-github-bot merged commit 882a781 into nodejs:main Aug 19, 2026
113 of 114 checks passed

nodejs-github-bot commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Landed in 882a781

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 19, 2026
MikeMcC399 deleted the revert-64227 branch August 19, 2026 06:46
Paraspandey-debugs mentioned this pull request Aug 20, 2026
Open
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
Revert "fs: fix close listener leak in FileHandle streams"
29b63dd 
This reverts commit 8488e13.

It was advised that the fix in question is broken since
it will unref the handle multiple times.

Signed-off-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
PR-URL: #65387
Refs: #64227
Refs: #64214
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
Revert "fs: fix close listener leak in FileHandle streams"
810929b 
This reverts commit 8488e13.

It was advised that the fix in question is broken since
it will unref the handle multiple times.

Signed-off-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
PR-URL: #65387
Refs: #64227
Refs: #64214
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
github-actions Bot mentioned this pull request Aug 25, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
ronag ronag approved these changes
ovflowd ovflowd approved these changes
atlowChemi atlowChemi approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL