sqlite: remove unused column name helper - #65401
Merged
nodejs-github-bot merged 1 commit intoAug 21, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Remove the unused column name helper from StatementExecutionHelper. It became unused after all() and get() switched to cached names. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #65401 +/- ##
==========================================
- Coverage 90.11% 90.09% -0.02%
==========================================
Files 752 752
Lines 252200 252191 -9
Branches 47433 47438 +5
==========================================
- Hits 227267 227222 -45
- Misses 16239 16277 +38
+ Partials 8694 8692 -2
... and 26 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
jasnell
approved these changes
Aug 20, 2026
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
geeksilva97
approved these changes
Aug 20, 2026
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
Remove the unused column name helper from StatementExecutionHelper. It became unused after all() and get() switched to cached names. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> PR-URL: #65401 Refs: #65276 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
Remove the unused column name helper from StatementExecutionHelper. It became unused after all() and get() switched to cached names. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> PR-URL: #65401 Refs: #65276 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #65276
Remove the unused column name helper from StatementExecutionHelper.
It became unused after all() and get() switched to cached names.