doc: fix broken GYP link in n-api.md - #65413
Merged
nodejs-github-bot merged 2 commits intoAug 22, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Replace the unavailable GYP website with the GYP documentation preserved in the Chromium source repository. Signed-off-by: HoonDongKang <d159123@naver.com>
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
legendecas
reviewed
Aug 20, 2026
legendecas
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I think we can update
Lines 197 to 198 in 5ba7e05
to
[node-gyp][] is a build system based on the [gyp-next][] tool and comes bundled with npm.The linked google repo is not maintained anyway.
Sorry, something went wrong.
lpinca
approved these changes
Aug 20, 2026
avivkeller
approved these changes
Aug 21, 2026
Copy link
Copy Markdown
Member
|
Please remove the link as the suggestion: #65413 (review), thanks! |
Sorry, something went wrong.
Google's GYP project is no longer maintained. Signed-off-by: HoonDongKang <d159123@naver.com>
Copy link
Copy Markdown
Contributor
Author
|
Sorry for the late response. I removed the link and updated the wording as suggested. I also retained the note that node-gyp requires Python, which wasn’t included in the suggestion. + node-gyp requires that Python be installed.Thank you! |
Sorry, something went wrong.
legendecas
approved these changes
Aug 22, 2026
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
Replace the unavailable GYP website with the GYP documentation preserved in the Chromium source repository. Signed-off-by: HoonDongKang <d159123@naver.com> PR-URL: #65413 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
Replace the unavailable GYP website with the GYP documentation preserved in the Chromium source repository. Signed-off-by: HoonDongKang <d159123@naver.com> PR-URL: #65413 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the broken GYP link in n-api.md.
The gyp.gsrc.io` website is no longer available, so the link has been replaced with the GYP documentation preserved in the Chromium Google Source repository.