doc: correct anchors for buffer.md - #6542
Closed
JacksonTian wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Comment thread
doc/api/buffer.md
Outdated
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Could you change only the href here, not the text itself? I think that makes more sense.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
hmmm, ok
Sorry, something went wrong.
the `buf.fill()` and `Buffer#indexOf` don't have correctly anchors
Copy link
Copy Markdown
Member
|
LGTM |
Sorry, something went wrong.
1 similar comment
Copy link
Copy Markdown
Member
|
LGTM |
Sorry, something went wrong.
jasnell
pushed a commit
that referenced
this pull request
May 6, 2016
the `buf.fill()` and `Buffer#indexOf` don't have correctly anchors PR-URL: #6542 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
May 17, 2016
the `buf.fill()` and `Buffer#indexOf` don't have correctly anchors PR-URL: #6542 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Copy link
Copy Markdown
Contributor
|
this is not landing cleanly on v4.x-staging |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
the buf.fill() and Buffer#indexOf don't have correctly anchors