permission: enforce addon permission in GetLinkedBinding - #65432
Merged
nodejs-github-bot merged 1 commit intoAug 24, 2026
Merged
permission: enforce addon permission in GetLinkedBinding#65432nodejs-github-bot merged 1 commit into
nodejs-github-bot merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
legendecas
approved these changes
Aug 20, 2026
BethGriggs
approved these changes
Aug 20, 2026
Copy link
Copy Markdown
Codecov Report❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
@@ Coverage Diff @@
## main #65432 +/- ##
==========================================
- Coverage 90.14% 90.12% -0.03%
==========================================
Files 746 752 +6
Lines 242764 252322 +9558
Branches 45739 47449 +1710
==========================================
+ Hits 218848 227407 +8559
- Misses 15426 16217 +791
- Partials 8490 8698 +208
... and 250 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
jasnell
approved these changes
Aug 20, 2026
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: #65432 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: #65432 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
process._linkedBinding() did not enforce the Addon permission check used by process.dlopen(). Apply the same permission check before resolving a linked binding, including after process.permission.drop('addon').