FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: improve commit queue failure comment by panva · Pull Request #65433 · nodejs/node · GitHub

/ node Public

tools: improve commit queue failure comment - #65433

Merged
nodejs-github-bot merged 5 commits into
nodejs:mainfrom
panva:improve-cq-failure-comment
Aug 22, 2026
Merged

tools: improve commit queue failure comment#65433
nodejs-github-bot merged 5 commits into
nodejs:mainfrom
panva:improve-cq-failure-comment

Conversation

panva commented Aug 20, 2026

Copy link
Copy Markdown
Member

Commit Queue failure comments currently hide the actionable reason and recovery steps inside the collapsed git node land output. This made e.g. a missing multiple-commit landing policy look like a generic queue failure.

Surface a concise reason before the full output. Give the missing policy case specific commit-queue-squash and commit-queue-rebase guidance. For other failures, show up to ten warning and error lines, falling back to the end of the output when none are tagged. These diagnostics preserve line breaks while allowing long lines to wrap.

Also explain how to retry, retain the full escaped output in a disclosure, and use a descriptive workflow link. Push and squash-merge failures now supply explicit reasons.

For a missing multiple-commit policy, the comment previously rendered as:

▸ Commit Queue failed

It now renders as:

Commit Queue failed

This pull request has multiple commits, but no landing policy was selected.

Add commit-queue-squash to land it as one commit, or commit-queue-rebase to land the commits separately.

The pull request was removed from the Commit Queue and labeled commit-queue-failed. After resolving the failure, remove that label and add commit-queue to retry.

▸ Full Commit Queue output

View workflow run

Other failures now surface their relevant output, for example:

Commit Queue failed

✘ No Jenkins CI runs detected

The pull request was removed from the Commit Queue and labeled commit-queue-failed. After resolving the failure, remove that label and add commit-queue to retry.

▸ Full Commit Queue output

View workflow run

panva requested a review from aduh95 August 20, 2026 14:18

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Aug 20, 2026
Comment thread tools/actions/commit-queue.sh Outdated
Comment thread tools/actions/commit-queue.sh Outdated
panva added 2 commits August 20, 2026 22:46
Commit Queue failure comments hid the actionable reason inside the
collapsed landing transcript.

Surface the reason and retry instructions before the full output. Add
specific guidance for a missing multi-commit policy and explicit reasons
for push and squash-merge failures.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
panva force-pushed the improve-cq-failure-comment branch from b3c5e02 to e513b51 Compare August 20, 2026 20:48
Comment thread tools/actions/commit-queue.sh Outdated
Signed-off-by: Filip Skokan <panva.ip@gmail.com>

aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM with a few nits

Comment thread tools/actions/commit-queue.sh Outdated
Comment thread tools/actions/commit-queue.sh Outdated
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
panva added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 20, 2026
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
panva added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Aug 21, 2026
panva requested a review from anonrig August 21, 2026 08:31
aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 21, 2026
nodejs-github-bot merged commit f411275 into nodejs:main Aug 22, 2026
28 of 30 checks passed

Copy link
Copy Markdown
Collaborator

Landed in f411275

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 22, 2026
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
Commit Queue failure comments hid the actionable reason inside the
collapsed landing transcript.

Surface the reason and retry instructions before the full output. Add
specific guidance for a missing multi-commit policy and explicit reasons
for push and squash-merge failures.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65433
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
Commit Queue failure comments hid the actionable reason inside the
collapsed landing transcript.

Surface the reason and retry instructions before the full output. Add
specific guidance for a missing multi-commit policy and explicit reasons
for push and squash-merge failures.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65433
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL