| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
Review requested:
|
Sorry, something went wrong.
Commit Queue failure comments hid the actionable reason inside the collapsed landing transcript. Surface the reason and retry instructions before the full output. Add specific guidance for a missing multi-commit policy and explicit reasons for push and squash-merge failures. Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
There was a problem hiding this comment.
LGTM with a few nits
Sorry, something went wrong.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Commit Queue failure comments hid the actionable reason inside the collapsed landing transcript. Surface the reason and retry instructions before the full output. Add specific guidance for a missing multi-commit policy and explicit reasons for push and squash-merge failures. Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #65433 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Commit Queue failure comments hid the actionable reason inside the collapsed landing transcript. Surface the reason and retry instructions before the full output. Add specific guidance for a missing multi-commit policy and explicit reasons for push and squash-merge failures. Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #65433 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
| Back | FazBrowse Home | New Git URL |
Commit Queue failure comments currently hide the actionable reason and recovery steps inside the collapsed git node land output. This made e.g. a missing multiple-commit landing policy look like a generic queue failure.
Surface a concise reason before the full output. Give the missing policy case specific commit-queue-squash and commit-queue-rebase guidance. For other failures, show up to ten warning and error lines, falling back to the end of the output when none are tagged. These diagnostics preserve line breaks while allowing long lines to wrap.
Also explain how to retry, retain the full escaped output in a disclosure, and use a descriptive workflow link. Push and squash-merge failures now supply explicit reasons.
For a missing multiple-commit policy, the comment previously rendered as:
It now renders as:
Other failures now surface their relevant output, for example: