quic: reset rejected HTTP/3 request streams with H3_REQUEST_REJECTED - #65442
Merged
nodejs-github-bot merged 1 commit intoAug 23, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
An incoming HTTP/3 request stream rejected without any application processing (the session has no stream consumer) is now reset with H3_REQUEST_REJECTED so the peer learns the request was not processed, per RFC 9114 section 4.1.1. The code is surfaced per-application like the existing no-error and internal-error codes, so non-HTTP/3 applications are unchanged. Fixes: nodejs#65441 Signed-off-by: Naman Trivedi <trivenay@amazon.com>
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #65442 +/- ##
==========================================
- Coverage 91.85% 90.10% -1.75%
==========================================
Files 400 752 +352
Lines 179110 252339 +73229
Branches 27351 47454 +20103
==========================================
+ Hits 164522 227382 +62860
- Misses 14258 16254 +1996
- Partials 330 8703 +8373
... and 484 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
jasnell
approved these changes
Aug 20, 2026
This comment was marked as outdated.
trivikr
approved these changes
Aug 20, 2026
This comment was marked as outdated.
This comment was marked as outdated.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
bjohansebas
approved these changes
Aug 22, 2026
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
An incoming HTTP/3 request stream rejected without any application processing (the session has no stream consumer) is now reset with H3_REQUEST_REJECTED so the peer learns the request was not processed, per RFC 9114 section 4.1.1. The code is surfaced per-application like the existing no-error and internal-error codes, so non-HTTP/3 applications are unchanged. Fixes: #65441 Signed-off-by: Naman Trivedi <trivenay@amazon.com> PR-URL: #65442 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
An incoming HTTP/3 request stream rejected without any application processing (the session has no stream consumer) is now reset with H3_REQUEST_REJECTED so the peer learns the request was not processed, per RFC 9114 section 4.1.1. The code is surfaced per-application like the existing no-error and internal-error codes, so non-HTTP/3 applications are unchanged. Fixes: #65441 Signed-off-by: Naman Trivedi <trivenay@amazon.com> PR-URL: #65442 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an incoming HTTP/3 request stream is rejected without any application processing (the session has no stream consumer), it is now reset with H3_REQUEST_REJECTED so the peer learns the request was not processed, per RFC 9114 §4.1.1. The code is surfaced per-application like the existing no-error/internal-error codes, so non-HTTP/3 applications are unchanged.
Fixes: #65441