FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: fix property names in os.networkInterfaces() example by hanityx · Pull Request #65469 · nodejs/node · GitHub

/ node Public

doc: fix property names in os.networkInterfaces() example - #65469

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
hanityx:doc-fix-os-networkinterfaces
Aug 23, 2026
Merged

doc: fix property names in os.networkInterfaces() example#65469
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
hanityx:doc-fix-os-networkinterfaces

Conversation

hanityx commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

The os.networkInterfaces() JSON example has colons in the property names,
such as "lo:" and "address:". These don't match the names listed above or
what os.networkInterfaces() actually returns.

It looks like the colons came in when the example was converted from a
JavaScript object literal to JSON.

Refs: #63200

Signed-off-by: hanityx <hanityx@gmail.com>
nodejs-github-bot added doc Issues and PRs related to the documentations. os Issues and PRs related to the os subsystem. labels Aug 21, 2026
lpinca added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 22, 2026
deokjinkim added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 23, 2026
nodejs-github-bot merged commit fbea5c3 into nodejs:main Aug 23, 2026
31 checks passed

Copy link
Copy Markdown
Collaborator

Landed in fbea5c3

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. os Issues and PRs related to the os subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL