[v26.x backport] crypto: remove obsolete BoringSSL shims and use available APIs - #65483
Closed
panva wants to merge 3 commits into
Closed
[v26.x backport] crypto: remove obsolete BoringSSL shims and use available APIs#65483panva wants to merge 3 commits into
panva wants to merge 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
This comment was marked as outdated.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## v26.x-staging #65483 +/- ##
=================================================
- Coverage 90.24% 90.22% -0.02%
=================================================
Files 729 729
Lines 242760 242760
Branches 46044 46050 +6
=================================================
- Hits 219073 219041 -32
- Misses 15133 15144 +11
- Partials 8554 8575 +21
... and 38 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
BoringSSL implements OPENSSL_zalloc and BN_secure_new and provides compatible secure heap status stubs. Use the common code paths. Remove ClientHello helpers left unused by the early callback migration and require the fixed ML-KEM private-key import error. Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: nodejs#65423 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Use BoringSSL's current RSA and DH validation results instead of maintaining backend-specific prechecks and collapsing key errors. Report negotiated TLS groups and the documented zero security level through BoringSSL's compatibility APIs. Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: nodejs#65423 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
panva
force-pushed
the
backport-65423-26.x
branch
from
b7ceb4e to
bc52379
Compare
August 23, 2026 15:09
Copy link
Copy Markdown
Contributor
@@ -87,12 +87,12 @@
-/nix/store/1k5vfgzqyn72h74v6ha9fihh7qbjrik0-boringssl-0.20260413.0 (aarch64-darwin)
-/nix/store/k7hvxfz5mi1jcnzvfgmadpj61vcc2w0k-boringssl-0.20260413.0 (aarch64-linux)
-/nix/store/pxmk721zyiw3n872vqiiz5cb05skmb34-boringssl-0.20260413.0 (x86_64-darwin)
-/nix/store/n9g5v0naw03kxri26nm4zj0q85ypa3f6-boringssl-0.20260413.0 (x86_64-linux)
-/nix/store/khfg0xszkmhb10fk7ghkx23b76nb1n8i-boringssl-0.20260413.0-bin (aarch64-darwin)
-/nix/store/f6qciy5r9706hxd78wajsn92k27wnrq4-boringssl-0.20260413.0-bin (aarch64-linux)
-/nix/store/jiz39z5bafzhy9qzq5d6gndi320p6gli-boringssl-0.20260413.0-bin (x86_64-darwin)
-/nix/store/rs4yhnrd1v39wjnll2ahdpx9cda3nakn-boringssl-0.20260413.0-bin (x86_64-linux)
-/nix/store/sfm292hxsmcbb49r35ww86wnhdp8x6vm-boringssl-0.20260413.0-dev (aarch64-darwin)
-/nix/store/i6ccv7jpy8gb35nnhaj0cdv8blkg1w4r-boringssl-0.20260413.0-dev (aarch64-linux)
-/nix/store/bzacx7cjjp1is1xh770bjid1ap15h66p-boringssl-0.20260413.0-dev (x86_64-darwin)
-/nix/store/2b288h3ihsdmm24lmz5wbjx89ib8jd6v-boringssl-0.20260413.0-dev (x86_64-linux)
+/nix/store/h0nnbhvw042c05840krknzp2gfnyan3n-boringssl-0.20260803.0 (aarch64-darwin)
+/nix/store/22rfr95xasl2rqqr0aiimqkd074nrgvp-boringssl-0.20260803.0 (aarch64-linux)
+/nix/store/lyjrr5k51c80cj8dgdhr6zgkbp4nmd7i-boringssl-0.20260803.0 (x86_64-darwin)
+/nix/store/zpda1sh11x0l9zf2jqyj6j33gk650wdy-boringssl-0.20260803.0 (x86_64-linux)
+/nix/store/kjvgsigj0lh1zc7lnyh93hqlv433z8pg-boringssl-0.20260803.0-bin (aarch64-darwin)
+/nix/store/f105al617fdlhhjm02919xj22dgyn552-boringssl-0.20260803.0-bin (aarch64-linux)
+/nix/store/s0zf1zkbjqgfpkfin8f1j3b0l6xrii90-boringssl-0.20260803.0-bin (x86_64-darwin)
+/nix/store/x3b5va756lzjpgkxvfkvfx23066hnmk2-boringssl-0.20260803.0-bin (x86_64-linux)
+/nix/store/i78kyxhs512a5d96si4lx5zvm76gq363-boringssl-0.20260803.0-dev (aarch64-darwin)
+/nix/store/6zz04nbxwxlz2m04lb1vk1xa79i1rz70-boringssl-0.20260803.0-dev (aarch64-linux)
+/nix/store/nqb5r8axdf6cnpldyv8ncd57ydm4mz18-boringssl-0.20260803.0-dev (x86_64-darwin)
+/nix/store/ilzac8c0icc8v48fzmmsjqam4rwsh7gp-boringssl-0.20260803.0-dev (x86_64-linux) |
Sorry, something went wrong.
aduh95
approved these changes
Aug 24, 2026
This comment was marked as outdated.
pimterry
approved these changes
Aug 24, 2026
This comment was marked as outdated.
This comment was marked as outdated.
This comment has been minimized.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #65483 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tim Perry <pimterry@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
BoringSSL implements OPENSSL_zalloc and BN_secure_new and provides compatible secure heap status stubs. Use the common code paths. Remove ClientHello helpers left unused by the early callback migration and require the fixed ML-KEM private-key import error. Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #65423 Backport-PR-URL: #65483 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tim Perry <pimterry@gmail.com>
Copy link
Copy Markdown
Contributor
|
Landed in ffe1e7c...137ff67 |
Sorry, something went wrong.
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
Use BoringSSL's current RSA and DH validation results instead of maintaining backend-specific prechecks and collapsing key errors. Report negotiated TLS groups and the documented zero security level through BoringSSL's compatibility APIs. Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #65423 Backport-PR-URL: #65483 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tim Perry <pimterry@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #65483 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tim Perry <pimterry@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
BoringSSL implements OPENSSL_zalloc and BN_secure_new and provides compatible secure heap status stubs. Use the common code paths. Remove ClientHello helpers left unused by the early callback migration and require the fixed ML-KEM private-key import error. Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #65423 Backport-PR-URL: #65483 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tim Perry <pimterry@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
Use BoringSSL's current RSA and DH validation results instead of maintaining backend-specific prechecks and collapsing key errors. Report negotiated TLS groups and the documented zero security level through BoringSSL's compatibility APIs. Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #65423 Backport-PR-URL: #65483 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tim Perry <pimterry@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #65423 to v26.x, this is a clean backport with one caveat, it overrides the boringssl version used by test-shared.yml to match that on main at the time #65423 landed.