FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: allow out-of-order replies in dgram tests by addaleax · Pull Request #6607 · nodejs/node · GitHub

/ node Public

test: allow out-of-order replies in dgram tests - #6607

Merged
addaleax merged 1 commit into
nodejs:masterfrom
addaleax:fix-udp-default-host-tests
May 10, 2016
ConversationCommits (1)ChecksFiles changed
Merged

test: allow out-of-order replies in dgram tests#6607
addaleax merged 1 commit into
nodejs:masterfrom
addaleax:fix-udp-default-host-tests

Conversation

addaleax commented May 5, 2016

Copy link
Copy Markdown
Member
Checklist
  • tests and code linting passes
  • a test and/or benchmark is included
  • the commit message follows commit guidelines
Affected core subsystem(s)

test, dgram

Description of change

Allow out of order replies in the flaky test-dgram{-upd6,}-send-default-host.js files by sorting the incoming replies after receiving them.

Fixes: #6577

/cc @Trott @santigimeno

addaleax added dgram Issues and PRs related to the dgram subsystem / UDP. test Issues and PRs related to the tests. labels May 5, 2016
bnoordhuis reviewed May 6, 2016
View reviewed changes
Comment thread test/parallel/test-dgram-send-default-host.js Outdated

bnoordhuis May 6, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Why are you passing toSend.length here?

addaleax May 6, 2016

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Making sure that the message event is invoked for each message – otherwise the test would accept messages just being dropped.

bnoordhuis May 6, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Apologies, I missed it was an argument to mustCall.

bnoordhuis commented May 6, 2016

Copy link
Copy Markdown
Member

LGTM

cjihrig commented May 6, 2016

Copy link
Copy Markdown
Contributor

LGTM

CI: https://ci.nodejs.org/job/node-test-pull-request/2526/

santigimeno commented May 6, 2016

Copy link
Copy Markdown
Member

LGTM

1 similar comment

jasnell commented May 6, 2016

Copy link
Copy Markdown
Member

LGTM

addaleax mentioned this pull request May 6, 2016
Closed
2 tasks

mcollina commented May 6, 2016

Copy link
Copy Markdown
Member

LGTM

mcollina commented May 6, 2016

Copy link
Copy Markdown
Member

BTW, can you please sweep through all dgram tests? I think I copied the structure of those from another one, which probably has the same issue.

addaleax commented May 8, 2016

Copy link
Copy Markdown
Member Author

@mcollina I went through them and there seemed to be no other tests with this problem, just these two.

mcollina commented May 8, 2016

Copy link
Copy Markdown
Member

@addaleax thx for checking and fixing!

addaleax force-pushed the fix-udp-default-host-tests branch from 76d7b00 to 2e66c82 Compare May 10, 2016 05:43
test: allow out-of-order replies in dgram tests
c5a8bd5 
Allow out of order replies in the flaky
`test-dgram{-upd6,}-send-default-host.js` files by sorting
the incoming replies after receiving them.

Fixes: nodejs#6577
PR-URL: nodejs#6607
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
addaleax force-pushed the fix-udp-default-host-tests branch from 2e66c82 to c5a8bd5 Compare May 10, 2016 05:48
addaleax merged this pull request into nodejs:master May 10, 2016
addaleax deleted the fix-udp-default-host-tests branch May 10, 2016 05:53
addaleax added a commit to addaleax/node that referenced this pull request May 10, 2016
test: allow out-of-order replies in dgram tests
aa34b43 
Allow out of order replies in the flaky
`test-dgram{-upd6,}-send-default-host.js` files by sorting
the incoming replies after receiving them.

PR-URL: nodejs#6607
Fixes: nodejs#6577
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
evanlucas pushed a commit that referenced this pull request May 17, 2016
test: allow out-of-order replies in dgram tests
01f010f 
Allow out of order replies in the flaky
`test-dgram{-upd6,}-send-default-host.js` files by sorting
the incoming replies after receiving them.

PR-URL: #6607
Fixes: #6577
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
evanlucas mentioned this pull request May 17, 2016
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dgram Issues and PRs related to the dgram subsystem / UDP. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL