doc: update the printed error stack in the default callback example - #6617
Closed
DavidCai1111 wants to merge 1 commit into
Closed
doc: update the printed error stack in the default callback example#6617DavidCai1111 wants to merge 1 commit into
DavidCai1111 wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
LGTM, but maybe we should truncate the stack trace earlier than we currently are (move the <etc.> up and drop some additional frames). Keeping the stack trace up to date seems like it could become a bother. |
Sorry, something went wrong.
DavidCai1111
force-pushed
the
optimize_fs_doc
branch
from
843de69 to
bd9c986
Compare
May 6, 2016 13:57
Copy link
Copy Markdown
Contributor
|
Nice. LGTM. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
+1 that's better. LGTM |
Sorry, something went wrong.
claudiorodriguez
pushed a commit
that referenced
this pull request
May 15, 2016
Update the error stack printed in the default callback example in the fs doc, matching the latest lib/fs.js. Truncates the stack to make it easier to update in the future. PR-URL: #6617 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
May 17, 2016
Update the error stack printed in the default callback example in the fs doc, matching the latest lib/fs.js. Truncates the stack to make it easier to update in the future. PR-URL: #6617 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description of change
Update the error stack printed in the default callback example, matching the latest lib/fs.js.