FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: make stdout buffer test more robust by Trott · Pull Request #6633 · nodejs/node · GitHub

/ node Public

test: make stdout buffer test more robust - #6633

Closed
Trott wants to merge 2 commits into
nodejs:masterfrom
Trott:know
ConversationCommits (2)ChecksFiles changed
Closed

test: make stdout buffer test more robust#6633
Trott wants to merge 2 commits into
nodejs:masterfrom
Trott:know

Conversation

Trott commented May 7, 2016

Copy link
Copy Markdown
Member
Checklist
  • tests and code linting passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

test-stdout-buffer-flush-on-exit is unfortunately non-deterministic. It
will, every so often, pass when it is supposed to fail. This is
currently guarded against by running the test with three different long
strings. This change increases it to five to reduce the false negatives.

test: make stdout buffer test more robust
af043d3 
test-stdout-buffer-flush-on-exit is unfortunately non-deterministic. It
will, every so often, pass when it is supposed to fail. This is
currently guarded against by running the test with three different long
strings. This change increases it to five to reduce the false negatives.
Trott added test Issues and PRs related to the tests. known issue test labels May 7, 2016
mscdex added the process Issues and PRs related to the process subsystem. label May 7, 2016
evanlucas reviewed May 7, 2016
View reviewed changes
Comment thread test/known_issues/test-stdout-buffer-flush-on-exit.js Outdated
}

[16, 18, 20].forEach((exponent) => {
[16, 18, 20, 21, 22].forEach((exponent) => {

evanlucas May 7, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

should it be adding 22 and 24 to stay consistent here? or are 21 and 22 magic somehow?

Trott May 7, 2016

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

22 is the biggest integer you can use before you start getting RangeError failures for Invalid string length.

evanlucas May 8, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Cool, figured there was a reason

Trott commented May 7, 2016

Copy link
Copy Markdown
Member Author

Stress test of current version:

Stress test with the version in this PR:

Weirdly and annoyingly, it's not any more reliable.

Closing for now in the hopes of figuring it out and re-opening...

Trott closed this May 7, 2016
Trott reopened this May 8, 2016

Trott commented May 8, 2016

Copy link
Copy Markdown
Member Author

Reopened. Increasing the number of tests to 14 seems to pump up the reliability quite a bit.

Current master stress test: https://ci.nodejs.org/job/node-stress-single-test/703/nodes=centos5-64/console

This PR: https://ci.nodejs.org/job/node-stress-single-test/704/nodes=centos5-64/console

Trott commented May 8, 2016

Copy link
Copy Markdown
Member Author

Current version fails about 1/3 of the time. Version in this PR didn't fail at all after 9999 runs.

Trott commented May 9, 2016

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/2541/

bnoordhuis commented May 9, 2016

Copy link
Copy Markdown
Member

LGTM

1 similar comment

jasnell commented May 9, 2016

Copy link
Copy Markdown
Member

LGTM

Trott mentioned this pull request May 9, 2016
Closed
2 tasks

santigimeno commented May 9, 2016

Copy link
Copy Markdown
Member

LGTM

MylesBorins commented May 10, 2016

Copy link
Copy Markdown
Contributor

landed in 0912b88

MylesBorins pushed a commit that referenced this pull request May 10, 2016
test: make stdout buffer test more robust
0912b88 
test-stdout-buffer-flush-on-exit is unfortunately non-deterministic. It
will, every so often, pass when it is supposed to fail. This is
currently guarded against by running the test with three different long
strings. This change increases it to five to reduce the false negatives.

PR-URL: #6633
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
evanlucas pushed a commit that referenced this pull request May 17, 2016
test: make stdout buffer test more robust
d740624 
test-stdout-buffer-flush-on-exit is unfortunately non-deterministic. It
will, every so often, pass when it is supposed to fail. This is
currently guarded against by running the test with three different long
strings. This change increases it to five to reduce the false negatives.

PR-URL: #6633
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
evanlucas mentioned this pull request May 17, 2016
Merged

MylesBorins commented Jun 2, 2016

Copy link
Copy Markdown
Contributor

@Trott lts?

Trott commented Jun 2, 2016

Copy link
Copy Markdown
Member Author

@thealphanerd Yes.

One thing about this and the other known issues PRs is that they will have to be landed in order. I think numerical order (by PR ID) ascending should be good.

MylesBorins pushed a commit that referenced this pull request Jul 11, 2016
test: make stdout buffer test more robust
e7e3f13 
test-stdout-buffer-flush-on-exit is unfortunately non-deterministic. It
will, every so often, pass when it is supposed to fail. This is
currently guarded against by running the test with three different long
strings. This change increases it to five to reduce the false negatives.

PR-URL: #6633
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 11, 2016
test: make stdout buffer test more robust
e644967 
test-stdout-buffer-flush-on-exit is unfortunately non-deterministic. It
will, every so often, pass when it is supposed to fail. This is
currently guarded against by running the test with three different long
strings. This change increases it to five to reduce the false negatives.

PR-URL: #6633
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
test: make stdout buffer test more robust
d370d42 
test-stdout-buffer-flush-on-exit is unfortunately non-deterministic. It
will, every so often, pass when it is supposed to fail. This is
currently guarded against by running the test with three different long
strings. This change increases it to five to reduce the false negatives.

PR-URL: #6633
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
test: make stdout buffer test more robust
b40cfa4 
test-stdout-buffer-flush-on-exit is unfortunately non-deterministic. It
will, every so often, pass when it is supposed to fail. This is
currently guarded against by running the test with three different long
strings. This change increases it to five to reduce the false negatives.

PR-URL: #6633
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins mentioned this pull request Jul 12, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
test: make stdout buffer test more robust
ab55d12 
test-stdout-buffer-flush-on-exit is unfortunately non-deterministic. It
will, every so often, pass when it is supposed to fail. This is
currently guarded against by running the test with three different long
strings. This change increases it to five to reduce the false negatives.

PR-URL: #6633
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
test: make stdout buffer test more robust
7c55f59 
test-stdout-buffer-flush-on-exit is unfortunately non-deterministic. It
will, every so often, pass when it is supposed to fail. This is
currently guarded against by running the test with three different long
strings. This change increases it to five to reduce the false negatives.

PR-URL: #6633
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Trott deleted the know branch January 13, 2022 22:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

process Issues and PRs related to the process subsystem. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL