FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc,events: fix a link typo by yorkie · Pull Request #6640 · nodejs/node · GitHub

/ node Public

doc,events: fix a link typo - #6640

Closed
yorkie wants to merge 1 commit into
nodejs:masterfrom
yorkie:fix/events-doc
Closed

doc,events: fix a link typo#6640
yorkie wants to merge 1 commit into
nodejs:masterfrom
yorkie:fix/events-doc

Conversation

yorkie commented May 8, 2016

Copy link
Copy Markdown
Contributor
Checklist
  • tests and code linting passes
  • a test and/or benchmark is included
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)
  • doc
  • events
Description of change

I guess someone did change the argument name, but not update the below links. Do we have a way to check the function links?

nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 8, 2016
mscdex added the events Issues and PRs related to the events subsystem / EventEmitter. label May 8, 2016

Copy link
Copy Markdown
Contributor

LGTM

1 similar comment

jasnell commented May 9, 2016

Copy link
Copy Markdown
Member

LGTM

yorkie commented May 10, 2016

Copy link
Copy Markdown
Contributor Author

Ping :-)

Copy link
Copy Markdown
Contributor

LGTM

Copy link
Copy Markdown
Contributor

Landed in 6e9a4ab. Thanks!

evanlucas closed this May 10, 2016
evanlucas pushed a commit that referenced this pull request May 10, 2016
PR-URL: #6640
Reviewed-By: Alexander Makarenko <estliberitas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
yorkie deleted the fix/events-doc branch May 10, 2016 11:49
evanlucas pushed a commit that referenced this pull request May 17, 2016
PR-URL: #6640
Reviewed-By: Alexander Makarenko <estliberitas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. events Issues and PRs related to the events subsystem / EventEmitter.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants


Back | FazBrowse Home | New Git URL