FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: pass python path to node-gyp by hefangshi · Pull Request #6646 · nodejs/node · GitHub

/ node Public

test: pass python path to node-gyp - #6646

Closed
hefangshi wants to merge 1 commit into
nodejs:masterfrom
hefangshi:pass-python-to-gyp
ConversationCommits (1)ChecksFiles changed
Closed

test: pass python path to node-gyp#6646
hefangshi wants to merge 1 commit into
nodejs:masterfrom
hefangshi:pass-python-to-gyp

Conversation

hefangshi commented May 9, 2016

Copy link
Copy Markdown
Contributor
Checklist
  • tests and code linting passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

node-gyp rebuild should use the same python interpreter as in Makefile
rather than let node-gyp guess the python path by itself.

bnoordhuis added build Issues and PRs related to build files or the CI. test Issues and PRs related to the tests. labels May 9, 2016

bnoordhuis commented May 9, 2016

Copy link
Copy Markdown
Member

LGTM. CI: https://ci.nodejs.org/job/node-test-pull-request/2544/

addaleax commented May 12, 2016

Copy link
Copy Markdown
Member

LGTM

addaleax commented May 12, 2016

Copy link
Copy Markdown
Member

@hefangshi You author name in this commit is given as “Sighless”. Is that intended or do you prefer to be listed (changelog, git log, AUTHORS file) with some other name? People typically prefer their full name, but ultimately it’s up to you.

hefangshi commented May 12, 2016

Copy link
Copy Markdown
Contributor Author

@addaleax Thanks for mention this, I prefer to use full name rather than "Sighless", is threre some way to change that?

bnoordhuis commented May 12, 2016

Copy link
Copy Markdown
Member

@hefangshi git commit --amend --author="Your Name <youremail@example.com>", then force-push to your feature branch. To make git remember your name and email:

$ git config --global user.name "Your Name"
$ git config --global user.email youremail@example.com

test: pass python path to node-gyp
b66fe3d 
node-gyp rebuild should use the same python interpreter as in Makefile
rather than let node-gyp guess the python path by itself.
hefangshi force-pushed the pass-python-to-gyp branch from f11b73d to b66fe3d Compare May 12, 2016 11:37

hefangshi commented May 12, 2016

Copy link
Copy Markdown
Contributor Author

@bnoordhuis @addaleax Thanks, already changed ;)

addaleax commented May 12, 2016

Copy link
Copy Markdown
Member

@hefangshi “hefangshi” is correct, right? Just checking to make sure it’s really what you want, because you just changed the name on your profile to “Fangshi He” and that would be okay just as well.

hefangshi commented May 12, 2016

Copy link
Copy Markdown
Contributor Author

@addaleax hefangshi is fine ;)

addaleax pushed a commit that referenced this pull request May 12, 2016
test: pass python path to node-gyp
25f8d04 
node-gyp rebuild should use the same python interpreter as in Makefile
rather than let node-gyp guess the python path by itself.

PR-URL: #6646
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

addaleax commented May 12, 2016

Copy link
Copy Markdown
Member

Thanks! Landed in 25f8d04.

addaleax closed this May 12, 2016
evanlucas pushed a commit that referenced this pull request May 17, 2016
test: pass python path to node-gyp
3f9d724 
node-gyp rebuild should use the same python interpreter as in Makefile
rather than let node-gyp guess the python path by itself.

PR-URL: #6646
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
evanlucas mentioned this pull request May 17, 2016
Merged

MylesBorins commented Jun 2, 2016

Copy link
Copy Markdown
Contributor

@addaleax lts?

addaleax commented Jun 2, 2016

Copy link
Copy Markdown
Member

@thealphanerd yep 👍

MylesBorins pushed a commit that referenced this pull request Jul 11, 2016
test: pass python path to node-gyp
41086e8 
node-gyp rebuild should use the same python interpreter as in Makefile
rather than let node-gyp guess the python path by itself.

PR-URL: #6646
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Jul 11, 2016
test: pass python path to node-gyp
e11df99 
node-gyp rebuild should use the same python interpreter as in Makefile
rather than let node-gyp guess the python path by itself.

PR-URL: #6646
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
test: pass python path to node-gyp
586997e 
node-gyp rebuild should use the same python interpreter as in Makefile
rather than let node-gyp guess the python path by itself.

PR-URL: #6646
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
test: pass python path to node-gyp
ef43d39 
node-gyp rebuild should use the same python interpreter as in Makefile
rather than let node-gyp guess the python path by itself.

PR-URL: #6646
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins mentioned this pull request Jul 12, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
test: pass python path to node-gyp
175a2a1 
node-gyp rebuild should use the same python interpreter as in Makefile
rather than let node-gyp guess the python path by itself.

PR-URL: #6646
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
test: pass python path to node-gyp
af4b56d 
node-gyp rebuild should use the same python interpreter as in Makefile
rather than let node-gyp guess the python path by itself.

PR-URL: #6646
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL