FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: ensure test-npm-install uses correct node by MylesBorins · Pull Request #6658 · nodejs/node · GitHub

/ node Public

test: ensure test-npm-install uses correct node - #6658

Merged
MylesBorins merged 1 commit into
nodejs:masterfrom
MylesBorins:npm-test-explicit-path
May 11, 2016
ConversationCommits (1)ChecksFiles changed
Merged

test: ensure test-npm-install uses correct node#6658
MylesBorins merged 1 commit into
nodejs:masterfrom
MylesBorins:npm-test-explicit-path

Conversation

MylesBorins commented May 9, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor
Checklist
  • tests and code linting passes
  • a test and/or benchmark is included
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

Currently it is possible that the shelled out instance of npm will use
the system copy of node. This PR changes the test to shim the build
directory into the path. This will ensure that npm will use the correct
version of node.

nodejs-github-bot added the test Issues and PRs related to the tests. label May 9, 2016

MylesBorins commented May 9, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

ci: https://ci.nodejs.org/job/node-test-pull-request/2550/
/cc @nodejs/testing
edit: CI is green

MylesBorins mentioned this pull request May 9, 2016
Closed
mscdex added the npm Issues and PRs related to the npm client dependency or the npm registry. label May 9, 2016

MylesBorins commented May 9, 2016

Copy link
Copy Markdown
Contributor Author

fixes: #6648

MylesBorins force-pushed the npm-test-explicit-path branch from 501ba75 to 65453b8 Compare May 9, 2016 21:04
Fishrock123 reviewed May 9, 2016
View reviewed changes
Comment thread test/parallel/test-npm-install.js Outdated

Fishrock123 May 9, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

nit?

addaleax commented May 10, 2016

Copy link
Copy Markdown
Member

Related to #6220 in any way?

MylesBorins commented May 10, 2016

Copy link
Copy Markdown
Contributor Author

@addaleax yes and no.

It is the same problem with npm v2 not respecting the node that called it. Not the same problem in that #6220 needs to be fixed via documentation afaik

MylesBorins force-pushed the npm-test-explicit-path branch from 65453b8 to 19c4240 Compare May 10, 2016 00:37

addaleax commented May 10, 2016

Copy link
Copy Markdown
Member

Okay, LGTM then.

MylesBorins commented May 10, 2016

Copy link
Copy Markdown
Contributor Author

another ci run

ci: https://ci.nodejs.org/job/node-test-pull-request/2553/

bnoordhuis reviewed May 10, 2016
View reviewed changes
Comment thread test/parallel/test-npm-install.js Outdated

bnoordhuis May 10, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Shouldn't that spell PATH?

MylesBorins May 10, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

indeed... good eye

MylesBorins force-pushed the npm-test-explicit-path branch from 19c4240 to e8543bb Compare May 10, 2016 15:53

MylesBorins commented May 10, 2016

Copy link
Copy Markdown
Contributor Author

nits addressed @bnoordhuis @Fishrock123

Fishrock123 commented May 10, 2016

Copy link
Copy Markdown
Contributor

lgtm if it works

MylesBorins commented May 10, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

ci mater: https://ci.nodejs.org/job/node-test-pull-request/2562/
ci v4.x: https://ci.nodejs.org/job/node-test-commit/3256/

I'm running CI against both master + v4.x as this fix should only really matter with npm v2

bnoordhuis commented May 10, 2016

Copy link
Copy Markdown
Member

LGTM

test: ensure test-npm-install uses correct node
738a1d6 
Currently it is possible that the shelled out instance of npm will use
the system copy of node. This PR changes the test to shim the build
directory into the path. This will ensure that npm will use the correct
version of node.

fixes: nodejs#6648

PR-URL: nodejs#6658
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins force-pushed the npm-test-explicit-path branch from e8543bb to 738a1d6 Compare May 11, 2016 19:21
MylesBorins merged commit 738a1d6 into nodejs:master May 11, 2016
MylesBorins pushed a commit that referenced this pull request May 11, 2016
test: ensure test-npm-install uses correct node
cfa3bea 
Currently it is possible that the shelled out instance of npm will use
the system copy of node. This PR changes the test to shim the build
directory into the path. This will ensure that npm will use the correct
version of node.

fixes: #6648

PR-URL: #6658
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins deleted the npm-test-explicit-path branch May 12, 2016 18:14
evanlucas pushed a commit that referenced this pull request May 17, 2016
test: ensure test-npm-install uses correct node
0c62bd1 
Currently it is possible that the shelled out instance of npm will use
the system copy of node. This PR changes the test to shim the build
directory into the path. This will ensure that npm will use the correct
version of node.

fixes: #6648

PR-URL: #6658
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
evanlucas mentioned this pull request May 17, 2016
Merged
MylesBorins pushed a commit that referenced this pull request May 18, 2016
test: ensure test-npm-install uses correct node
cc4c518 
Currently it is possible that the shelled out instance of npm will use
the system copy of node. This PR changes the test to shim the build
directory into the path. This will ensure that npm will use the correct
version of node.

fixes: #6648

PR-URL: #6658
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins mentioned this pull request May 18, 2016
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

npm Issues and PRs related to the npm client dependency or the npm registry. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL