FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: test commit for nodejs-github-bot by Fishrock123 · Pull Request #6674 · nodejs/node · GitHub

/ node Public

test: test commit for nodejs-github-bot - #6674

Closed
Fishrock123 wants to merge 1 commit into
nodejs:masterfrom
Fishrock123:github-bot-jenkins-status
ConversationCommits (1)ChecksFiles changed
Closed

test: test commit for nodejs-github-bot#6674
Fishrock123 wants to merge 1 commit into
nodejs:masterfrom
Fishrock123:github-bot-jenkins-status

Conversation

Fishrock123 commented May 10, 2016

Copy link
Copy Markdown
Contributor

Do Not Merge

Tracking testing issue for nodejs/github-bot#35

Proxy Jenkins build status to GitHub statuses

Current status at nodejs/github-bot#35 (comment)

Fishrock123 added wip Issues and PRs that are still a work in progress. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels May 10, 2016
nodejs-github-bot added the test Issues and PRs related to the tests. label May 10, 2016
Fishrock123 removed the test Issues and PRs related to the tests. label May 10, 2016
Fishrock123 mentioned this pull request May 10, 2016
Merged

phillipj commented May 11, 2016 •
edited
Loading

Copy link
Copy Markdown
Member

@Fishrock123 @jbergstroem highfive (see below)

jbergstroem commented May 11, 2016

Copy link
Copy Markdown
Member

Ok, I'll add progress to more jobs. For now it will be pass/fail but I'll add as we move forward.

jbergstroem commented May 11, 2016

Copy link
Copy Markdown
Member

Also, I've added the boolean flag (default false) to test-pr and test-commit, meaning all jobs should inherit from it.

Fishrock123 commented May 11, 2016

Copy link
Copy Markdown
Contributor Author

Looks like the linter aborted here, @jbergstroem is it possible to make Jenkins send "build aborted" on abort rather than "errors found"?

Fishrock123 commented May 11, 2016

Copy link
Copy Markdown
Contributor Author

CI was https://ci.nodejs.org/job/node-test-pull-request/2576/

new CI: https://ci.nodejs.org/job/node-test-pull-request/2580/

Fishrock123 mentioned this pull request May 11, 2016
Closed

Fishrock123 commented May 11, 2016

Copy link
Copy Markdown
Contributor Author

@jbergstroem hmm, strange, it don't update on new CI? All the links seems to be linked to different runs too.

phillipj commented May 11, 2016

Copy link
Copy Markdown
Member

@Fishrock123 we've got some issues figuring out the correct SHA to provide to the bot, related to rebasing.

Fishrock123 commented May 11, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Testing with no rebasing: https://ci.nodejs.org/job/node-test-pull-request/2584/

edit: no dice, maybe it's disabled

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. wip Issues and PRs that are still a work in progress.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL