FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test,win: skip addons/load-long-path on WOW64 by orangemocha · Pull Request #6675 · nodejs/node · GitHub

/ node Public

test,win: skip addons/load-long-path on WOW64 - #6675

Closed
orangemocha wants to merge 0 commit into
nodejs:masterfrom
JaneaSystems:orangemocha-Node3667
ConversationCommits (0)ChecksFiles changed
Closed

test,win: skip addons/load-long-path on WOW64#6675
orangemocha wants to merge 0 commit into
nodejs:masterfrom
JaneaSystems:orangemocha-Node3667

Conversation

orangemocha commented May 10, 2016

Copy link
Copy Markdown
Contributor
Checklist
  • tests and code linting passes
  • a test and/or benchmark is included
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

test,win

Description of change

This test fails on WOW64 because of a bug in the OS, and there is
no acceptable wokaround.

Ref: #3667

nodejs-github-bot added the test Issues and PRs related to the tests. label May 10, 2016

Fishrock123 commented May 10, 2016

Copy link
Copy Markdown
Contributor

What kind of system is WOW64?

Fishrock123 added the windows Issues and PRs related to the Windows platform. label May 10, 2016

bnoordhuis commented May 10, 2016

Copy link
Copy Markdown
Member

LGTM although it's more commonly spelled as "WoW64", I think?

@Fishrock123 Windows 32 bits on a Windows 64 bits host.

orangemocha commented May 10, 2016

Copy link
Copy Markdown
Contributor Author

I went with the official spelling by Microsoft, I can change it if you feel strongly about it.

https://msdn.microsoft.com/en-us/library/windows/desktop/aa384274(v=vs.85).aspx

C:\>dir /b %windir%\*wow64
SysWOW64

bnoordhuis commented May 10, 2016

Copy link
Copy Markdown
Member

No strong feelings.

orangemocha commented May 12, 2016

Copy link
Copy Markdown
Contributor Author

I'll wait for #6697 to land and adopt the new skip syntax.

addaleax commented May 24, 2016

Copy link
Copy Markdown
Member

@orangemocha #6697 has landed, you should be able to use the new syntax here.

orangemocha force-pushed the orangemocha-Node3667 branch from f1d5293 to ec9f8f4 Compare May 25, 2016 12:37

orangemocha commented May 25, 2016

Copy link
Copy Markdown
Contributor Author

Updated, thanks!

cjihrig commented May 25, 2016

Copy link
Copy Markdown
Contributor

LGTM

orangemocha commented May 26, 2016

Copy link
Copy Markdown
Contributor Author

https://ci.nodejs.org/job/node-test-pull-request/2806/

orangemocha commented May 27, 2016

Copy link
Copy Markdown
Contributor Author

I am confident that the CI failures on ARM are unrelated to this change. /cc @nodejs/testing https://ci.nodejs.org/job/node-test-binary-arm/2285/RUN_SUBSET=6,label=pi1-raspbian-wheezy/

Landing shortly.

orangemocha added a commit that referenced this pull request May 27, 2016
test,win: skip addons/load-long-path on WOW64
6e2ae8a 
This test fails on WOW64 because of a bug in the OS, and there is
no acceptable workaround.

Ref: #3667

PR-URL: #6675
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
orangemocha force-pushed the orangemocha-Node3667 branch from ec9f8f4 to 6e2ae8a Compare May 27, 2016 10:08
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request May 30, 2016
test,win: skip addons/load-long-path on WOW64
5729993 
This test fails on WOW64 because of a bug in the OS, and there is
no acceptable workaround.

Ref: nodejs#3667

PR-URL: nodejs#6675
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
rvagg pushed a commit that referenced this pull request Jun 2, 2016
test,win: skip addons/load-long-path on WOW64
ea287fc 
This test fails on WOW64 because of a bug in the OS, and there is
no acceptable workaround.

Ref: #3667

PR-URL: #6675
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>

gibfahn commented Jul 4, 2016

Copy link
Copy Markdown
Member

@orangemocha could this be backported? Still seeing this on 4.4.7.

orangemocha added a commit to JaneaSystems/node that referenced this pull request Jul 5, 2016
test,win: skip addons/load-long-path on WOW64
8b4c557 
This test fails on WOW64 because of a bug in the OS, and there is
no acceptable workaround.

Ref: nodejs#3667

PR-URL: nodejs#6675
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
orangemocha mentioned this pull request Jul 5, 2016
Merged
2 tasks

orangemocha commented Jul 5, 2016

Copy link
Copy Markdown
Contributor Author

@gibm : I opened #7537 to backport it.

orangemocha added a commit that referenced this pull request Jul 8, 2016
test,win: skip addons/load-long-path on WOW64
350e8c6 
This test fails on WOW64 because of a bug in the OS, and there is
no acceptable workaround.

Ref: #3667

PR-URL: #6675
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 11, 2016
test,win: skip addons/load-long-path on WOW64
d5a4a1f 
This test fails on WOW64 because of a bug in the OS, and there is
no acceptable workaround.

Ref: #3667

PR-URL: #6675
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
test,win: skip addons/load-long-path on WOW64
279f3b3 
This test fails on WOW64 because of a bug in the OS, and there is
no acceptable workaround.

Ref: #3667

PR-URL: #6675
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
MylesBorins mentioned this pull request Jul 12, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
test,win: skip addons/load-long-path on WOW64
84b8061 
This test fails on WOW64 because of a bug in the OS, and there is
no acceptable workaround.

Ref: #3667

PR-URL: #6675
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
test,win: skip addons/load-long-path on WOW64
e544b1c 
This test fails on WOW64 because of a bug in the OS, and there is
no acceptable workaround.

Ref: #3667

PR-URL: #6675
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL